Add new controllers for new CRDs #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test setup achieves 100% test coverage for testutil, but with extra test injection code, which is rather excessive and unclear.
Also, some tests were missing parallel flag. This is now corrected, and the whole resource-handler test suite, including the integration tests usually complete within 10 sec.
rytswd
changed the title
These markers should be better placed with API definitions, so that the RBAC manifests generation can stay simple and only check out the api/ directory.
This was referenced Dec 13, 2025
fernando-villalba
approved these changes
Dec 14, 2025
Member
Author
|
Because of the large number of commits, I'm doing a squash merge on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Add resource-handler implementation with 100% test coverage for cell, shard, and toposerver.
Some remaining items that will NOT be tackled in this PR
Other than that, all the existing test cases would allow easily updating the API definitions and iterate from here on.