Skip to content

Conversation

@rytswd
Copy link
Member

@rytswd rytswd commented Dec 15, 2025

This also adds extra labels for future usages (which should trigger the CI build for test coverage).

@github-actions
Copy link

🔬 Go Test Coverage Report

Summary

Coverage Type Result
Threshold 0%
Previous Test Coverage Unknown%
New Test Coverage 100.0%

Status

✅ PASS

Detail

Show New Coverage
github.com/numtide/multigres-operator/pkg/resource-handler/controller/cell/cell_controller.go:32:		Reconcile			100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/cell/cell_controller.go:82:		handleDeletion			100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/cell/cell_controller.go:106:		reconcileMultiGatewayDeployment	100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/cell/cell_controller.go:140:		reconcileMultiGatewayService	100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/cell/cell_controller.go:175:		updateStatus			100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/cell/cell_controller.go:205:		buildConditions			100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/cell/cell_controller.go:240:		SetupWithManager		100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/cell/multigateway.go:38:			BuildMultiGatewayDeployment	100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/cell/multigateway.go:109:			BuildMultiGatewayService	100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/metadata/labels.go:83:			BuildStandardLabels		0.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/metadata/labels.go:96:			AddCellLabel			100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/metadata/labels.go:102:			AddClusterLabel			100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/metadata/labels.go:108:			AddShardLabel			100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/metadata/labels.go:114:			AddDatabaseLabel		100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/metadata/labels.go:120:			AddTableGroupLabel		100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/metadata/labels.go:129:			MergeLabels			100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/shard/containers.go:42:			buildPostgresContainer		100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/shard/containers.go:71:			buildMultiPoolerSidecar		100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/shard/containers.go:110:			buildPgctldInitContainer	100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/shard/containers.go:128:			buildMultiOrchContainer		100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/shard/containers.go:156:			buildPgctldVolume		100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/shard/containers.go:166:			buildDataVolumeClaimTemplate	100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/shard/containers.go:177:			getPoolServiceID		100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/shard/labels.go:11:			buildPoolLabels			100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/shard/multiorch.go:23:			BuildMultiOrchDeployment	100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/shard/multiorch.go:73:			BuildMultiOrchService		100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/shard/pool_service.go:21:			BuildPoolHeadlessService	100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/shard/pool_service.go:52:			buildPoolName			100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/shard/pool_statefulset.go:28:		BuildPoolStatefulSet		100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/shard/pool_statefulset.go:93:		buildPoolVolumeClaimTemplates	100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/shard/ports.go:27:			buildMultiPoolerContainerPorts	100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/shard/ports.go:49:			buildPoolHeadlessServicePorts	100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/shard/ports.go:74:			buildMultiOrchContainerPorts	100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/shard/ports.go:91:			buildMultiOrchServicePorts	100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/shard/shard_controller.go:32:		Reconcile			100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/shard/shard_controller.go:93:		handleDeletion			100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/shard/shard_controller.go:117:		reconcileMultiOrchDeployment	100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/shard/shard_controller.go:154:		reconcileMultiOrchService	100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/shard/shard_controller.go:192:		reconcilePool			100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/shard/shard_controller.go:212:		reconcilePoolStatefulSet	100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/shard/shard_controller.go:251:		reconcilePoolHeadlessService	100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/shard/shard_controller.go:291:		updateStatus			100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/shard/shard_controller.go:334:		buildConditions			100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/shard/shard_controller.go:362:		SetupWithManager		100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/storage/pvc.go:18:			BuildPVCTemplate		100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/toposerver/container_env.go:13:		buildContainerEnv		100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/toposerver/container_env.go:41:		buildPodIdentityEnv		100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/toposerver/container_env.go:66:		buildEtcdConfigEnv		100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/toposerver/container_env.go:116:		buildEtcdClusterPeerList	100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/toposerver/ports.go:20:			buildContainerPorts		100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/toposerver/ports.go:48:			buildHeadlessServicePorts	100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/toposerver/ports.go:78:			buildClientServicePorts		100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/toposerver/service.go:17:			BuildHeadlessService		100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/toposerver/service.go:48:			BuildClientService		100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/toposerver/statefulset.go:39:		BuildStatefulSet		100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/toposerver/statefulset.go:116:		buildVolumeClaimTemplates	100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/toposerver/toposerver_controller.go:32:	Reconcile			100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/toposerver/toposerver_controller.go:91:	reconcileStatefulSet		100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/toposerver/toposerver_controller.go:128:	reconcileHeadlessService	100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/toposerver/toposerver_controller.go:166:	reconcileClientService		100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/toposerver/toposerver_controller.go:204:	updateStatus			100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/toposerver/toposerver_controller.go:239:	buildConditions			100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/toposerver/toposerver_controller.go:267:	handleDeletion			100.0%
github.com/numtide/multigres-operator/pkg/resource-handler/controller/toposerver/toposerver_controller.go:291:	SetupWithManager		100.0%
total:														(statements)			100.0%

@rytswd rytswd marked this pull request as ready for review December 15, 2025 11:50
Copy link
Collaborator

@fernando-villalba fernando-villalba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Gave a couple of suggestions but feel free to ignore and merge as it is.

@rytswd
Copy link
Member Author

rytswd commented Dec 16, 2025

As we have no enforced CI success for the PR to be merged, I'm going ahead with the merge on this.

@rytswd rytswd merged commit 631e64b into main Dec 16, 2025
@rytswd rytswd deleted the add-coverage-cicd branch December 16, 2025 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants