WIP Use a separate resolver package for template handling#93
Closed
WIP Use a separate resolver package for template handling#93
Conversation
This supports template and default handling, which can be used for both controller logic as well as validation with webhook.
🔬 Go Test Coverage ReportSummary
StatusDetailShow New Coverage |
Member
Author
|
In order for this to work on local machine, we can simply test with the following # At repository root
❯ make setup-envtest
❯ go work init
❯ go work use ./pkg/resolver ./pkg/cluster-handler
❯ cd ./pkg/cluster-handler
❯ go test ./... -tags=integration -cover -count=1
ok github.com/numtide/multigres-operator/pkg/cluster-handler/controller/multigrescluster 7.799s coverage: 100.0% of statements
ok github.com/numtide/multigres-operator/pkg/cluster-handler/controller/tablegroup 7.971s coverage: 100.0% of statements |
Collaborator
|
Implemented on PR 90. @rytswd Please remember to delete branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: This has the exact same code change as #90, except for premature go.mod change being removed. The commits have been moved around to ensure resolver package can be merged first, and
cluster-handlercan update the Go module dependency withgo mod tidyonce it is available from the remote.NOTE: If we wanted to make this PR fully merge-able even before #92 is merged, we can pull in changes from that branch with
go get -u github.com/numtide/multigres-operator/pkg/resolver@introduce-resolver-package. That would fully compile before and after the #92 is merged, if and only if #92 is merged as is, without any rebasing or squashing.