Conversation
This commit completely refactors the `config/samples` directory to reflect the
final v1alpha1 API design and current Multigres system capabilities.
**Changes:**
* **Removed Outdated Artifacts:** Deleted `sample.yaml`, `reference.yaml`, and the `child-resources/` directory. These contained obsolete patterns (like unmanaged child resources) that do not align with the Operator's "Single Source of Truth" architecture.
* **Added Functional Scenarios:**
* `minimal.yaml`: Demonstrates the "Ultra-Minimalist" use case relying on webhooks/namespace defaults.
* `template-defaults.yaml`: A production-ready example using the Template system.
* `no-templates.yaml`: A example using full inline specifications.
* `external_etcd.yaml`: Demonstrates Brownfield/External Etcd integration and mixed cell topology (shared vs. isolated).
* **Added Template Samples:** Created `config/samples/templates/` with `core.yaml`, `cell.yaml`, and `shard.yaml` to support the template-based examples.
**Constraints Applied:**
All new samples strictly adhere to the current Multigres routing limitation by configuring only the System Database (`postgres`) and the Default TableGroup (`default`). This ensures that users applying these samples get a fully functional, routable cluster out of the box.
🔬 Go Test Coverage ReportSummary
Status✅ PASS DetailShow New Coverage |
rytswd
approved these changes
Jan 5, 2026
Member
rytswd
left a comment
rytswd
left a comment
There was a problem hiding this comment.
This removed the child resources which were useful to test resource-handlers. I'll approve this for now, but will reinstate those resources for e2e testing scenarios in a different directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit completely refactors the
config/samplesdirectory to reflect the final v1alpha1 API design and current Multigres system capabilities.Changes:
sample.yaml,reference.yaml, and thechild-resources/directory. These contained obsolete patterns (like unmanaged child resources) that do not align with the Operator's "Single Source of Truth" architecture.minimal.yaml: Demonstrates the "Ultra-Minimalist" use case relying on webhooks/namespace defaults.template-defaults.yaml: A production-ready example using the Template system.no-templates.yaml: A example using full inline specifications.external_etcd.yaml: Demonstrates Brownfield/External Etcd integration and mixed cell topology (shared vs. isolated).config/samples/templates/withcore.yaml,cell.yaml, andshard.yamlto support the template-based examples.Constraints Applied:
All new samples strictly adhere to the current Multigres routing limitation by configuring only the System Database (
postgres) and the Default TableGroup (default). This ensures that users applying these samples get a fully functional, routable cluster out of the box.