fix: on-unmatched option #298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@zimbatm this was never merged. The change still seems relevant when comparing with latest main. |
Contributor
|
is there any blockers on this being merged? it is confusing that there exists an option in documentation and in-code that seems to do nothing. |
zimbatm
force-pushed
the
fix/on-unmatched
branch
from
9af0bd6 to
3ed7ec8
Compare
vidhanio
reviewed
Jan 11, 2026
| type = types.submodule { | ||
| freeformType = configFormat.type; | ||
| options = { | ||
| global = { |
Contributor
There was a problem hiding this comment.
should there be an mkRenamedOptionModule to notify users to migrate from global -> top level settings?
zimbatm
force-pushed
the
fix/on-unmatched
branch
from
3ed7ec8 to
139d5ad
Compare
Also moves excludes in the root of the settings, as global has been deprecated. Signed-off-by: Brian McGee <brian@bmcgee.ie>
zimbatm
force-pushed
the
fix/on-unmatched
branch
from
139d5ad to
5eb7434
Compare
vidhanio
added a commit
to vidhanio/vidhanix
that referenced
this pull request
Jan 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also moves excludes in the root of the settings, as global has been deprecated.
Fixes #297