Enforce formatter name doesn't contain bad characters#513
Merged
brianmcgee merged 2 commits intomainfrom Jan 30, 2025
Merged
Conversation
Signed-off-by: Brian McGee <brian@bmcgee.ie>
jfly
approved these changes
Jan 24, 2025
Signed-off-by: Brian McGee <brian@bmcgee.ie>
brianmcgee
force-pushed
the
feat/validate-formatter-name
branch
from
da69590 to
43f943f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the title suggests.
Recently discovered in https://github.com/numtide/treefmt-nix that names with
/could be passed through and would break execution. This enforces simple formatted names in config and when passing asformattersarg.Also fixes misuse of the assertions API.