Skip to content

Conversation

@OsirisTerje
Copy link
Member

The issue nunit/nunit#815 was documented for the Ignore attribute in #172, but it should also be updated for the TestCase, so this does that.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds documentation for the proper usage of named parameters with the TestCase attribute in NUnit, specifically addressing issue #815. The documentation clarifies how to correctly use Ignore, Explicit, and Category parameters to avoid accidentally applying them to the entire test fixture instead of individual test cases.

  • Adds comprehensive examples and warnings about correct vs incorrect syntax for TestCase attribute named parameters
  • Includes code examples demonstrating proper usage of Ignore, Explicit, and Category parameters
  • Removes unused using statements from the examples file

Reviewed Changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.

File Description
TestCaseAttributeExamples.cs Removes unused imports and adds example methods for TestCase with Ignore, Explicit, and Category parameters
testcase.md Adds detailed documentation section explaining proper syntax for named parameters and common pitfalls

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@SeanKilleen
Copy link
Member

@OsirisTerje Actually I'm going to go ahead and make some small language fixes which I don't think you'll mind, rather than give you a bunch of review comments to address

@SeanKilleen
Copy link
Member

@OsirisTerje I've made some commits with edits. Assuming you agree with them, this is good to merge now. Feel free to edit anything you don't like 👍

@OsirisTerje
Copy link
Member Author

Thanks @SeanKilleen , really appreciate it!

@OsirisTerje OsirisTerje merged commit d6e7616 into master Sep 11, 2025
7 checks passed
@OsirisTerje OsirisTerje deleted the testcaseupdates branch September 11, 2025 07:23
github-actions bot pushed a commit that referenced this pull request Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants