-
Notifications
You must be signed in to change notification settings - Fork 161
Updated doc on repeat attribute #1071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates documentation for the RepeatAttribute by adding examples, clarifying behavior options, and noting a known issue. The documentation now better explains the StopOnFailure property and includes practical code examples.
- Moved inline code examples to dedicated snippet files for better maintainability
- Added documentation for the StopOnFailure property available from version 4.3.0
- Added warning about NUnit issue 5031 affecting console output and failure reporting
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/snippets/Snippets.NUnit/Attributes/RepeatAttributeExample.cs | New snippet file containing three test examples demonstrating different RepeatAttribute behaviors |
| docs/articles/nunit/writing-tests/attributes/repeat.md | Updated documentation with improved structure, examples references, and additional behavior details |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
SeanKilleen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me! Just one question/suggestion.
Updated doc on repeat attribute 473bcc4
Moved examples to the snippets
Added info on StopOnFailure property
Added warning on NUnit Issue 5031