-
Notifications
You must be signed in to change notification settings - Fork 161
fix snippets #1092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix snippets #1092
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes build warnings in the NUnit documentation snippet projects by adding warning suppressions and cleaning up unnecessary using statements. The main changes include adding NoWarn configurations to suppress NUnit analyzer warnings, adding targeted pragma directives for nullability warnings, reformatting XML indentation, and removing redundant using statements that are covered by implicit usings.
- Added
NoWarnconfiguration to suppress NUnit analyzer warnings (NUnit2007, NUnit2009, CS7022) at the project level - Added targeted pragma directives to suppress specific warnings in test code examples
- Removed redundant explicit using statements now covered by implicit usings
- Reformatted XML indentation in project files for consistency
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
docs/snippets/Snippets.NUnitLite/Snippets.NUnitLite.csproj |
Added NoWarn configuration for analyzer warnings and reformatted XML indentation |
docs/snippets/Snippets.NUnit/Snippets.NUnit.csproj |
Added NoWarn configuration for analyzer warnings and reformatted XML indentation |
docs/snippets/Snippets.NUnit/ConstraintExamples.cs |
Added pragma directives to suppress NUnit2007 and NUnit2009 warnings |
docs/snippets/Snippets.NUnit/ClassicAssertExamples.cs |
Removed redundant using statements, added multiple pragma directives to suppress nullability and NUnit analyzer warnings |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@SeanKilleen I haven't touched the files the markdown linter complains about now. |
|
@OsirisTerje I'll fix this shortly. I think the issue is that I'm probably using latest rather than pinning to a version, and they likely added a new rule that we don't care about. Will investigate and fix ASAP. |
|
When the linter was successful it was running version Compare vs |
|
@mikkelbu yes, as I noted, it likely added a new rule that we need to disable. I will fix this up. |
SeanKilleen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Approved and build fixed
Co-authored-by: Sean Killeen <[email protected]> c5193e7
Fixed all warning in snippets project