Fix Double-loading of assemblies #1810
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry-picked from 3f854b2
Cherry picked from f11499a
Try to load assembly from trusted list, before to start using some complex logic and enumerate AdditinalFrameworkDirectories Improve logging for assembly resolving process
(cherry picked from commit f642e99)
Loading of unmanaged assemblies suffers from the same issues as loading managed assemblies in that the wrong deps.json is used by default. This updates the TestAssemblyLoadContext to use the exact same pattern for loading unmanaged assemblies as managed assemblies. 1. Use the default assembly loading logic (I'm unsure if we actually need this since, in both managed and unmanaged, the base AssemblyLoadContext logic is a no-op and it's actually the VM that has some logic for loading assemblies). 2. Use an AssemblyDependencyResolver for the test assembly. 3. Check in the same folder as the test assembly (in case the dependencies are not fully specified in deps.json). Resolves #1253
…hich were added/merged after this PR was created.
Adding yml file for CI build
Integrate TestAssemblyLoadContext changes to version315
Fix crashing bug when trying to run an unmanaged test assembly.
Add unit tests of netcore3.1 driver
Issue 1777
There is an indirect reference through Castle.Core to a non-existing version of System.ComponentModel.TypeConverter If I add System.ComponentModel.TypeConverter locally, the compiler complains that it isn't used ...
Enhanced assembly resolution for windows and aspnetcore
Ignore .addins files in XML format
Handle prerelease dotnet runtimes correctly
Prepare for release
Eliminate use of our custom AssemblyLoadContext
Issue 1807
Fix problems in assembly loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.