Allow launching browsers without an Artisan command (for use in queues, etc.) #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey, @nunomaduro i think this can be merged right ? |
|
@nunomaduro Do you think this PR can be merged? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over the years there have been a number of discussions about using Laravel-Console-Dusk in non-Artisan contexts, e.g. in a queue. I had this need recently and as far as I can tell, the only thing that really prevents people from doing this is the reliance on
nunomaduro/laravel-console-taskfor the pretty-printing of the progress messages.This PR makes the provision of a
Commandobject optional, and allows Laravel-Console-Dusk to boot even in non-console contexts (by way of a configuration option). In non-Artisan contexts, it will not uselaravel-console-taskfor reporting.Likely resolves #4 and #17. It seems to be working for our purposes, but I am open to any suggestions on how we might differently architect this.