Fix incorrect default value for ‘linesCountBeforeDeclare’ #672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
The checks are failing on 1 error relating to return type on SniffDecorator::register(), and 2 issues relating to PHP version 8.0 conflicting with symfony/console and symfony/process being locked to v5.9 or v6.4+ (no versions available for 6.0 to 6.3). The 2 issues with PHP 8.0 are never going to pass for those 2 as it is attempting to use the stable versions of Laravel 9 / Symfony Skeleton, however minimum versions of symfony/console and symfony/process for both are 6.0, therefore won't use 5.9, and 6.4 needs minimum PHP 8.1. |
Collaborator
|
Thanks @pauljohnston, looks like this was covered in #697 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option 'newlinesCountBeforeDeclare' hasn't existed since v7.0.0 and causes the warning 'Creation of dynamic property SlevomatCodingStandard\Sniffs\TypeHints\DeclareStrictTypesSniff::$newlinesCountBeforeDeclare is deprecated in /vendor/nunomaduro/phpinsights/src/Domain/InsightLoader/SniffLoader.php on line 40'. The correct option is 'linesCountBeforeDeclare', see https://github.com/slevomat/coding-standard/blob/master/doc/type-hints.md#slevomatcodingstandardtypehintsdeclarestricttypes-