Enable NSS wrapper only if /tmp is writable#3
Merged
sivanov-nuodb merged 1 commit intomainfrom Jan 21, 2025
Merged
Conversation
adriansuarez
approved these changes
Jan 21, 2025
adriansuarez
left a comment
There was a problem hiding this comment.
Looks good.
The way we deal with this in the main container is that the /tmp directory has an ephemeral volume mounted on it. I wonder if we can do the same thing here, or use the same volume (though there might be a timing issue with which container creates the virtual user and group entries).
But this might not even matter if we only need the uid and gid to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The container will fail if
readOnlyRootFilesystem=trueand no volume ismounted in
/tmp. This is the case in NuoDB Helm charts withnuocollector-configandbackup-hookscontainers.Changes
Enable NSS wrapper only if
/tmpis writable.Notes
The changes are reviewed more easily with
show whitespacescheckbox disabled.