Skip to content

Added pynuoadmin#5

Merged
sivanov-nuodb merged 2 commits intomainfrom
sivanov/pynuoadmin
Jan 22, 2025
Merged

Added pynuoadmin#5
sivanov-nuodb merged 2 commits intomainfrom
sivanov/pynuoadmin

Conversation

@sivanov-nuodb
Copy link
Collaborator

Added pynuoadmin in nuodb/nuodb-sidecar Docker image. This is required so
that the backup hooks server can pause/resume archiving using nuocmd. By
default all Python modules installed by pip go into /home/nuodb/.local
directory. Setup the shell so that required environment variables for executing
nuocmd are exported.


# Copy tools code as nuodb user
USER 1000:1000
USER 1000:0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the reason we are assigning the root group?

Copy link

@adriansuarez adriansuarez Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1000:0 is the default uid:gid for the nuodb user. The root group is used because of details with how OpenShift manages permissions.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the point of using pynuoadmin was to have the backup hooks use the python API directly and not go through the CLI. Is that coming in a separate PR?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The backup hooks server uses nuocmd which is why we wanted to pull pynuoadmin (it delivers the nuocmd executable as well). We are planning to change the backup hooks so use python library directly instead of creating subprocess but this is a separate work.

Copy link

@adriansuarez adriansuarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@sivanov-nuodb sivanov-nuodb merged commit e5cf605 into main Jan 22, 2025
2 checks passed
@sivanov-nuodb sivanov-nuodb deleted the sivanov/pynuoadmin branch January 22, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants