feat: dynamic role for operations #252
Conversation
|
|
||
| configRequest.EnvVars = obj.EnvVarMap | ||
|
|
||
| // Add operation roles if present |
There was a problem hiding this comment.
theres ton of these unnecessary comments, can we clean these out?
There was a problem hiding this comment.
Yepp, left them in for later will clean before merge, mostly claude, got lot of labour work done with it
pkg/plans/types/composite_plan.go
Outdated
| FetchImageMetadataPlan *FetchImageMetadataPlan `json:"fetch_image_metadata_plan,omitempty"` | ||
| SandboxRunPlan *SandboxRunPlan `json:"sandbox_run_plan,omitempty"` | ||
|
|
||
| // Auth for cloud providera |
| ) | ||
|
|
||
| type OperationRoleRuleRequest struct { | ||
| Principal string `json:"principal" validate:"required"` // "nuon::component:name", "nuon::sandbox", "nuon::action:name" |
There was a problem hiding this comment.
what up with these comments? are they needed? we wouldn't want to keep these up to date to different versions.
also, we probably can solve for that making operation and principal typed so the type describes the options.
|
|
||
| type EntityOperationRoleMap map[app.OperationType]string | ||
|
|
||
| func EntityOperationRoleMapFromHstore(hstore map[string]*string) EntityOperationRoleMap { |
There was a problem hiding this comment.
Recommend using our pkg/db/generics and just working with map[string]string here
|
This PR was marked as stale, and will be closed after 3 more days. Add the #keep-open label to prevent this from being closed. |
someshkoli
force-pushed
the
sk/ft-dynamic-operation-roles
branch
from
f3f25a0 to
711b7b7
Compare
|
This PR was marked as stale, and will be closed after 3 more days. Add the #keep-open label to prevent this from being closed. |
- removes unwanted comments - fixes missing entity role assignment for composite plans
someshkoli
force-pushed
the
sk/ft-dynamic-operation-roles
branch
from
711b7b7 to
213229b
Compare
|
This PR was marked as stale, and will be closed after 3 more days. Add the #keep-open label to prevent this from being closed. |
3 participants
feat: temporary dynamic role selection
feat: add role selector to component sandbox and actions workflow on runtimne
feat: add ability to pass in role via api and store them into respective run tables
add azure credentials to composite plan auth
make sure break glass workflow works