-
Notifications
You must be signed in to change notification settings - Fork 4
chore: consolidate old rendering function #318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
a7d1998 to
f49d69e
Compare
|
This PR was marked as stale, and will be closed after 3 more days. Add the #keep-open label to prevent this from being closed. |
|
This PR was marked as stale, and will be closed after 3 more days. Add the #keep-open label to prevent this from being closed. |
3 similar comments
|
This PR was marked as stale, and will be closed after 3 more days. Add the #keep-open label to prevent this from being closed. |
|
This PR was marked as stale, and will be closed after 3 more days. Add the #keep-open label to prevent this from being closed. |
|
This PR was marked as stale, and will be closed after 3 more days. Add the #keep-open label to prevent this from being closed. |
|
This PR was marked as stale, and will be closed after 3 more days. Add the #keep-open label to prevent this from being closed. |
|
This PR was marked as stale, and will be closed after 3 more days. Add the #keep-open label to prevent this from being closed. |
|
This PR was marked as stale, and will be closed after 3 more days. Add the #keep-open label to prevent this from being closed. |
|
This PR was marked as stale, and will be closed after 3 more days. Add the #keep-open label to prevent this from being closed. |
|
This PR was marked as stale, and will be closed after 3 more days. Add the #keep-open label to prevent this from being closed. |
|
This PR was marked as stale, and will be closed after 3 more days. Add the #keep-open label to prevent this from being closed. |
|
This PR was marked as stale, and will be closed after 3 more days. Add the #keep-open label to prevent this from being closed. |
|
This PR was marked as stale, and will be closed after 3 more days. Add the #keep-open label to prevent this from being closed. |
This consolidates an issue with the old rendering, and removes the legacy function.
While in here, adding some tests for the render-struct method.
@erickyellott I opted out of changing the other places in the ctl-api to use render-struct. Figured we'd let this
marinate a bit, and you could take that on when you have time.