[T2A3][T05-A3] Marx Low#89
Open
marxlow wants to merge 3 commits intonus-cs2103-AY1617S1:masterfrom
marxlow:T2A3
Open
[T2A3][T05-A3] Marx Low#89marxlow wants to merge 3 commits intonus-cs2103-AY1617S1:masterfrom marxlow:T2A3
marxlow wants to merge 3 commits intonus-cs2103-AY1617S1:masterfrom
marxlow:T2A3
Conversation
|
Hi @marxlow, your pull request title is invalid. It should be in the format of Note that this comment is posted by a bot sorting all the pull request submissions. |
yamgent
pushed a commit
to yamgent/addressbook-level1
that referenced
this pull request
Aug 5, 2018
…-AY1617S1#90) The default storage file 'addressbook.txt' is not provided by default. The program has to create a new storage file, and this process is written in the program's log. Due to the additional information in the log, the first test run after cloning the master always result in failure, as the additional information creates a difference between actual.txt and expected.txt, causing the test to fail. Let's add the default storage file 'addressbook.txt' into the test folder so that the runtests.bat will stop failing on first run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finished the task activities.