[T6A3][F11-C3] Le Minh Duc #848
Open
darrenlmd wants to merge 3 commits intonus-cs2103-AY1617S1:masterfrom
Open
[T6A3][F11-C3] Le Minh Duc #848darrenlmd wants to merge 3 commits intonus-cs2103-AY1617S1:masterfrom
darrenlmd wants to merge 3 commits intonus-cs2103-AY1617S1:masterfrom
Conversation
… class' own method prepare() (which overrides the parent's class prepare() method)
…om parser and put them inside the appropriate PreparedCommand classes
cmkumar87
reviewed
Oct 7, 2016
cmkumar87
left a comment
cmkumar87
left a comment
There was a problem hiding this comment.
@acuodancer Please review and close PR. I believe you had tried to make parser OCP compliant. Please also try implementing DI and DIP.
| import seedu.addressbook.data.exception.IllegalValueException; | ||
| import seedu.addressbook.preparedcommands.PreparedCommand; | ||
|
|
||
| import java.util.*; |
There was a problem hiding this comment.
resolve imports properly. It is easy to do with eclipse shortcut.
| switch (commandWord) { | ||
| PreparedCommand pc = new PreparedCommand(arguments); | ||
| return pc.prepare(); | ||
| /*switch (commandWord) { |
There was a problem hiding this comment.
Don't comment out code that is not being used. It is an ugly practice when a revision control system such as git is available. We can simply revert a change if it doesn't work. So, if you want to remove / move a chunk of of code commit after doing so to create a point to which you can revert to, if you wish so later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.