[T6A3][F10-C4]Li Xiaowei#849
Open
LiXiaoooowei wants to merge 2 commits intonus-cs2103-AY1617S1:masterfrom
LiXiaoooowei:T6A3
Open
[T6A3][F10-C4]Li Xiaowei#849LiXiaoooowei wants to merge 2 commits intonus-cs2103-AY1617S1:masterfrom LiXiaoooowei:T6A3
LiXiaoooowei wants to merge 2 commits intonus-cs2103-AY1617S1:masterfrom
LiXiaoooowei:T6A3
Conversation
chanjunweimy
reviewed
Oct 1, 2016
| private StorageFile storage; | ||
| private AddressBook addressBook; | ||
|
|
||
| public StorageStub storage; |
There was a problem hiding this comment.
Hmm... if you look at the expected UML diagram, Logic should point to Storage, so it should be public Storage storage. :)
| public TemporaryFolder saveFolder = new TemporaryFolder(); | ||
|
|
||
| private StorageFile saveFile; | ||
| private StorageStub saveFile; |
There was a problem hiding this comment.
Good job! You can consider using Storage saveFile too, since Storage saveFile = new StorageStub() works too! But you did correctly, no worries! ^^
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready to view