[T6A3][T14-C2] Chen Rui Wen#852
Open
ruiwen905 wants to merge 2 commits intonus-cs2103-AY1617S1:masterfrom
Open
[T6A3][T14-C2] Chen Rui Wen#852ruiwen905 wants to merge 2 commits intonus-cs2103-AY1617S1:masterfrom
ruiwen905 wants to merge 2 commits intonus-cs2103-AY1617S1:masterfrom
Conversation
|
@ruiwen905 Some comments added. Please close the PR after reading them. |
|
|
||
| /* abstraction for Logic and StorageFile | ||
| * to reduce dependency | ||
| * */ |
There was a problem hiding this comment.
Format error for header comments. All classes, interfaces, and non-trivial methods should have javadoc format header comments.
|
|
||
| public abstract class Storage { | ||
| /** Default file path used if the user doesn't provide the file name. */ | ||
| public static final String DEFAULT_STORAGE_FILEPATH = "addressbook.txt"; |
There was a problem hiding this comment.
This doesn't seem to help if you create a class for cloud storage. Only keep requisite members and methods in abstract class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.