Refactor save command by KhooDesmond · Pull Request #217 · nus-cs2103-AY1617S1/addressbook-level4

KhooDesmond · 2016-11-05T12:50:12Z

No description provided.

Update DeveloperGuide

…ing task panels

…nd floating task panels" This reverts commit 4246a13.

floating task panels" This reverts commit 4246a13.

…ing task panels

Modify add and edit command documentation

…-edit-command Update UserGuide

…ents Sort deadline and events

Modify edit function

# Conflicts: # src/main/java/seedu/malitio/commons/core/Messages.java

# Conflicts: # src/main/java/seedu/malitio/model/Malitio.java

Support listing a specific type of task

Ensure valid events (fixes #33)

Improve ui and errors

Eg. it will not capture the "end" in friend as a keyword for an end date.

…_for_task_keywords_properly edit parser to parse input correctly by ignoring suffix of keywords.

…edited_task UI will scroll to the task which is changed/added

Refactor EditCommandTest

Modify format to follow java coding standard Add collation tags "//@@author A0129595N" for collation

…d_and_test Refactoring & ensure java coding standards are followed

Edit add and edit command

Add the restriction on task name

Update UserGuide.md

Update DeveloperGuide.md

…lines that has date format 11-Nov-2016, 22:00 (Fri)

# Conflicts: # src/main/java/seedu/malitio/logic/parser/Parser.java

nus-se-pr-bot · 2016-11-05T12:54:27Z

Hi @KhooDesmond, your pull request title is invalid. It should be in the format of [Activity ID][Team ID] Your name, where [Activity Id] has no dashes or spaces (e.g. [T2A3] stands for Tutorial 2 Activity 3) and [Team ID] has one dash only and no spaces (e.g. [W14-A2] means Wednesday 2pm (14 hrs), Phase A, Team 2). Please follow the instructions given strictly and edit your title for reprocessing.

Submit only one activity per pull request (unless otherwise stated in instructions) and do remember to create your branches from the commit where the master branch is pointing at so that each PR you submit only consist of commits meant for the activity.

Note: this comment is posted by a bot. If you believe this is done in error, please create an issue at cs2103-pr-bot and add a link to this PR.

annabeleng and others added 30 commits October 19, 2016 10:50

Merge pull request #22 from CS2103AUG2016-T13-C3/update-developerguide

fb617ec

Update DeveloperGuide

Update FindCommand to find keywords in all event, deadlines and float…

4246a13

…ing task panels

Revert "Update FindCommand to find keywords in all event, deadlines a…

802dccb

…nd floating task panels" This reverts commit 4246a13.

Merge branch 'master' of https://github.com/CS2103AUG2016-T13-C3/main

2caf1d8

floating task panels" This reverts commit 4246a13.

Update FindCommand to find keywords in all event, deadlines and float…

cb683f2

…ing task panels

change some naming issues

4dffa0e

Update UserGuide

814ac5d

Modify add and edit command documentation

Merge pull request #25 from CS2103AUG2016-T13-C3/update-userguide-add…

b388fd2

…-edit-command Update UserGuide

Merge pull request #23 from CS2103AUG2016-T13-C3/sort_deadline_and_ev…

4df7de7

…ents Sort deadline and events

Update link to UI image

f68b40b

Enhance find command to find only floating task, deadline or schedule

8e127fb

Fix bug that displays wrong find result

804e17e

Merge branch 'master' of https://github.com/CS2103AUG2016-T13-C3/main

89889ec

Update Parser to send the correct parameters to EditCommand

37b11d6

Refactor all tests to match latest model

462f384

Fixed error in DeadlineListPanel

fdebb77

Support deletion of events and deadlines

121cfa2

Merge pull request #26 from CS2103AUG2016-T13-C3/modify_edit_function

f6ba06a

Modify edit function

Merge branch 'find_command'

7f66c81

# Conflicts: # src/main/java/seedu/malitio/commons/core/Messages.java

Merge branch 'delete_command'

873e58f

# Conflicts: # src/main/java/seedu/malitio/model/Malitio.java

Fix some minor errors caused by merge.

96c5ef0

Support listing a specific type of task

4d819d5

Fix delete function

9248b45

Merge pull request #30 from CS2103AUG2016-T13-C3/list_command

dd2e126

Support listing a specific type of task

Fix error in test case

de1563a

Update Storage API documentation, fixes #18

a7d378c

Make sure events start time is before end time

48ccc91

Fix some errors, ensure editted events have start time before end time

f0d3821

Merge pull request #34 from CS2103AUG2016-T13-C3/ensure_valid_events

336401b

Ensure valid events (fixes #33)

Fixed bugs in delete command

9fbfe33

KhooDesmond and others added 28 commits November 3, 2016 14:59

Fix panel title font style

82220b4

Fix ellipsis of index problem

3189111

Merge pull request #82 from CS2103AUG2016-T13-C3/improve_ui_and_errors

4e7eb1c

Improve ui and errors

edit parser to parse input correctly by ignoring suffix of keywords.

ae3c82b

Eg. it will not capture the "end" in friend as a keyword for an end date.

Merge pull request #83 from CS2103AUG2016-T13-C3/edit_parser_to_check…

37e1a10

…_for_task_keywords_properly edit parser to parse input correctly by ignoring suffix of keywords.

updated grayout events that are overdue

a039cf8

UI will scroll to the task which is changed/added

4e99996

change to (un)completing (un)completed task message.

26f23f2

Merge pull request #84 from CS2103AUG2016-T13-C3/UI_scroll_to_new_or_…

5dd5051

…edited_task UI will scroll to the task which is changed/added

Refactor EditCommand

ce86120

Refactor EditCommandTest

display day of week, fix find command to accommodate this change

3a76457

Update README.md

3f007bc

Add header comments for methods in some classes.

325b796

Modify format to follow java coding standard Add collation tags "//@@author A0129595N" for collation

Merge pull request #85 from CS2103AUG2016-T13-C3/refactor_edit_comman…

b99c805

…d_and_test Refactoring & ensure java coding standards are followed

Update UserGuide.md

1309833

Edit add and edit command

Update UserGuide.md

0748160

Add the restriction on task name

Merge pull request #87 from CS2103AUG2016-T13-C3/annabeleng-patch-1

604deb7

Update UserGuide.md

Update UserGuide.md

983d805

Merge pull request #88 from CS2103AUG2016-T13-C3/annabeleng-patch-2

3295b65

Update UserGuide.md

Update UserGuide.md

4f7b479

Merge pull request #89 from CS2103AUG2016-T13-C3/annabeleng-patch-3

aff29ad

Update UserGuide.md

Update DeveloperGuide.md

3396132

Remove browser icon from architecture

1c171ba

Merge pull request #90 from CS2103AUG2016-T13-C3/annabeleng-patch-4

37fb6ab

Update DeveloperGuide.md

Fix bug with parsing, in particular parsing name from events and dead…

5e9efc5

…lines that has date format 11-Nov-2016, 22:00 (Fri)

Merge branch 'display_date_format'

6252717

# Conflicts: # src/main/java/seedu/malitio/logic/parser/Parser.java

Fix add deadline bug

000e684

refactor save command

d1df69f

nus-se-pr-bot added the FormatCheckRequested label Nov 5, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor save command#217

Refactor save command#217
KhooDesmond wants to merge 337 commits intonus-cs2103-AY1617S1:masterfrom
CS2103AUG2016-T13-C3:refactor_save_command

KhooDesmond commented Nov 5, 2016

Uh oh!

nus-se-pr-bot commented Nov 5, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

KhooDesmond commented Nov 5, 2016

Uh oh!

nus-se-pr-bot commented Nov 5, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants