[T7][W11-C3] by zavfel · Pull Request #75 · nus-cs2103-AY1617S1/addressbook-level4

zavfel · 2016-10-06T04:03:08Z

No description provided.

jeffryhartanto · 2016-10-07T08:38:41Z

docs/UserGuide.md

-Format: `add NAME p/PHONE_NUMBER e/EMAIL a/ADDRESS [t/TAG]...` 
+### Adding a task: `add` `do` `complete`
+#### Adds an event to Mastermind  
+Format: `add "TASK", at/TIME, on/DATE [t/TAG...]`  


In the description you mention event then in the command you use TASK, it's confusing.

jeffryhartanto · 2016-10-07T08:45:20Z

docs/UserGuide.md

+* `find Dinner`  
+  Returns `Dinner on 10/10/16 at 1900hrs (Date)`.
+* `find "cs2010 ps10"`  
+  Returns `CS2010 PS10 on 11 Oct by 1000hrs (Assignment)`.


You can mention what those double quotes mean.

jeffryhartanto · 2016-10-07T08:47:49Z

docs/UserGuide.md

+* `find date`  
+  Returns `Dinner on 10 Oct at 1900hrs (Date,meals)`.
+* `find "exam,assignment"`  
+  Returns `CS2010 PS10 on 11 Oct by 1000hrs (Assignment)`.


I assume using double quotes here will return any task that has those 2 tags. If so, you need give an explanation and change your return example.

jeffryhartanto · 2016-10-07T08:49:17Z

docs/UserGuide.md

-Deletes the specified person from the address book. Irreversible.<br>
+* `list`<br>
+  `edit 1 Lunch`<br>
+  Selects the 2nd task in Mastermind and edit the task to Lunch from Dinner.


I don't think you need to mention from Dinner, since nobody knows that.

jeffryhartanto · 2016-10-07T08:50:40Z

docs/UserGuide.md

+  Selects the 2nd task in Mastermind and edit the task to Lunch from Dinner.
+* `find CS2010` <br> 
+  `edit 1 on/2010`<br>
+  Selects the 1st task in the results of the `find` command and edit the date from 1110 to 2010.


Similar to above, you don't need to mention from 1110.

jeffryhartanto · 2016-10-07T08:52:48Z

docs/UserGuide.md

+
+Example:
+* `undo`  
+  COMMAND removed.


COMMAND removed? Need to find better wording for this. :)

jeffryhartanto · 2016-10-07T08:53:33Z

docs/UserGuide.md

-  The index **must be a positive integer** 1, 2, 3, ...
+Example:
+* `redo`  
+  COMMAND repeated.


COMMAND repeated? Need to find better word for this. :)

jeffryhartanto · 2016-10-07T08:55:07Z

docs/UserGuide.md

+
+Example:
+* `clear deadlines`
+  All tasks in deadlines are cleared.


When viewed, the description is not positioned under the clear deadline.

jeffryhartanto · 2016-10-07T08:55:45Z

docs/UserGuide.md

+
+### Clearing all entries: `clearall`
+Clears all tasks available from Mastermind  
+>>>>>>> master


Forgot to remove this after resolving conflict, :)

jeffryhartanto · 2016-10-07T08:59:01Z

Some comments added. Please close the PR after reading comments. Remember to keep a reasonable level of code quality at all time. Code quality is not something you can do later.

okkhoy · 2016-10-08T01:35:54Z

docs/UserGuide.md

-#### Adding a person: `add`
-Adds a person to the address book<br>
-Format: `add NAME p/PHONE_NUMBER e/EMAIL a/ADDRESS [t/TAG]...` 
+### Adding a task: `add` `do` `complete`


can you think of providing just one add command and decide on which type of task it is based on the input parameters?

okkhoy · 2016-10-08T01:36:55Z

docs/UserGuide.md

+#### Adds an event to Mastermind  
+Format: `add "TASK", at/TIME, on/DATE [t/TAG...]`  
+#### Adds a task with deadline to Mastermind  
+Format: `complete "TASK" by/TIME on/DATE [t/TAG...]`  


complete in the normal sense means to mark something as completed, no?

okkhoy · 2016-10-08T01:38:19Z

docs/UserGuide.md

-> The search is case sensitive, the order of the keywords does not matter, only the name is searched, 
-and persons matching at least one keyword will be returned (i.e. `OR` search).
+>* At least one optional argument is required.
+>* Can edit only one of the field for the task.


this seems to be an unnecessary limitation, don't you think so?

okkhoy · 2016-10-08T01:39:52Z

docs/UserGuide.md

-Format: `find KEYWORD [MORE_KEYWORDS]`
+### Editing a task : `edit`
+Edits the task identified by the index number used in the last task listing.  
+Format: `edit INDEX [TASK] [at/TIME] [on/DATE] [t/TAGS...]`


you have three commands for adding a task, each of different type. however, edit is just one.
does edit handle all three types of tasks? if yes, why not add do the same ;-)

okkhoy · 2016-10-08T01:40:46Z

docs/UserGuide.md

-Format: `find KEYWORD [MORE_KEYWORDS]`
+### Editing a task : `edit`
+Edits the task identified by the index number used in the last task listing.  
+Format: `edit INDEX [TASK] [at/TIME] [on/DATE] [t/TAGS...]`


if i add a floating task, can I edit it to include a start and/or end time? i.e. convert from floating task to deadline or event?

okkhoy · 2016-10-08T01:43:46Z

docs/UserGuide.md

+  Selects the 2nd task in Mastermind and edit the task to Lunch from Dinner.
+* `find CS2010` <br> 
+  `edit 1 on/2010`<br>
+  Selects the 1st task in the results of the `find` command and edit the date from 1110 to 2010.


errr.. i thought 1110 is time rather than date!

okkhoy · 2016-10-08T01:46:48Z

docs/UserGuide.md

-#### Adding a person: `add`
-Adds a person to the address book<br>
-Format: `add NAME p/PHONE_NUMBER e/EMAIL a/ADDRESS [t/TAG]...` 
+### Adding a task: `add` `do` `complete`


you need to specify somewhere, the date and time formats you support in the application.

Updated Memory Storage test

Updated storage memory test

- TaskBuilder and AddCommandBuilder now provides a systematic and safe way to create respective objects. - Refactor Parser to improve SLAP on prepareAdd - All Command object now inherits the ability to raise an event to update the last action row in the UI

…mand Refactoring. Added TaskBuilder and AddCommandBuilder.

add ImportCommand

- Added header comments on non-trivial methods.

…feedback Refactor/issue 168 feedback

# Conflicts: # src/main/java/harmony/mastermind/model/ModelManager.java # src/main/java/harmony/mastermind/ui/MainWindow.java

Relocate command test

# Resolved Conflicts: # src/main/java/harmony/mastermind/logic/commands/MarkCommand.java # src/main/java/harmony/mastermind/logic/commands/UnmarkCommand.java # src/main/java/harmony/mastermind/model/ModelManager.java # src/main/java/harmony/mastermind/ui/MainWindow.java

add test for findtag and upcoming

Remove println

Test_parsersearch

Added manual testing step.

…ing_authors_Hui_Qi Refactoring and adding authors hui qi

Commented

…ments editted comments

tagging and comments

updated tags

update images

nus-se-pr-bot assigned jeffryhartanto Oct 6, 2016

jeffryhartanto reviewed Oct 7, 2016

View reviewed changes

jeffryhartanto added the Reviewed label Oct 7, 2016

okkhoy reviewed Oct 8, 2016

View reviewed changes

zavfel closed this Oct 13, 2016

zavfel reopened this Oct 23, 2016

LuMiN0uSaRc and others added 23 commits October 30, 2016 18:14

Test case for storage memory

39dd1c3

Testing of deadline for storage memory

44d4c6a

test for events memory storage

8d3bbe1

Merge pull request #177 from CS2103AUG2016-W11-C3/Storage_Memory_Test

cb4c51f

Updated Memory Storage test

Updated test cases

4437b72

fixed test cases

ca4b216

Merge pull request #178 from CS2103AUG2016-W11-C3/Storage_Memory_Test

9f5c81c

Updated storage memory test

Update comment.

f2cd92e

Merge pull request #179 from CS2103AUG2016-W11-C3/refactoring/add-com…

3b90dd9

…mand Refactoring. Added TaskBuilder and AddCommandBuilder.

add ImportCommand

9727586

Merge pull request #180 from CS2103AUG2016-W11-C3/importCommand

bdb1891

add ImportCommand

Merge branch 'master' into importCommand

15a763f

Refactor isDue to improve SLAP.

7f4bc43

- Added header comments on non-trivial methods.

Added @@author at appropriate place. Added comments header.

d29727c

Merge pull request #181 from CS2103AUG2016-W11-C3/refactor/issue-168-…

bb95d46

…feedback Refactor/issue 168 feedback

refactoring, removing of confirm with user

a33d807

test cases for xmlTaskManagerStorage

0f989a8

more test cases for storage

df06141

Merge branch 'master' into RelocateCommandTest

a643737

# Conflicts: # src/main/java/harmony/mastermind/model/ModelManager.java # src/main/java/harmony/mastermind/ui/MainWindow.java

Merge pull request #182 from CS2103AUG2016-W11-C3/RelocateCommandTest

bb0c878

Relocate command test

major refactoring

f1edc03

LuMiN0uSaRc and others added 30 commits November 7, 2016 20:55

i tried

850c418

add Upcoming test

a7460ab

add find tag test

e98e1d0

Merge pull request #249 from CS2103AUG2016-W11-C3/updateTest

f3cf096

add test for findtag and upcoming

magic

5907c87

Merge pull request #250 from CS2103AUG2016-W11-C3/removing_println()

a476a9c

Remove println

Merge pull request #248 from CS2103AUG2016-W11-C3/Test_ParserSearch

41803b5

Test_parsersearch

update author

6cdb495

removed unusued code

5837f29

Added manual testing step.

7868e01

Merge pull request #252 from CS2103AUG2016-W11-C3/test/manual-testing

788b6ce

Added manual testing step.

removed lines of code

7905e78

remove unused lines...

1942535

commeneted

022f192

Merge pull request #251 from CS2103AUG2016-W11-C3/Refactoring_and_add…

295e334

…ing_authors_Hui_Qi Refactoring and adding authors hui qi

Merge pull request #253 from CS2103AUG2016-W11-C3/Remove_history_code

3816baa

Commented

tagging and comments

6529316

editted comments

092002c

Merge pull request #255 from CS2103AUG2016-W11-C3/Hui_Qi_editting_com…

38fec63

…ments editted comments

Merge pull request #254 from CS2103AUG2016-W11-C3/0.5AlbertTagging

f61cf1b

tagging and comments

updated tags

d031d08

Merge pull request #256 from CS2103AUG2016-W11-C3/0.5DylanTagging

85572f1

updated tags

added DG & UG.

1923799

Added logger.

77619bb

Update about me.

9579aec

update images

ee29ad3

added in memory

5559f47

Merge pull request #258 from CS2103AUG2016-W11-C3/fixImage

1a85fe6

update images

Collate.

92608aa

Merge branch 'master' of github.com:CS2103AUG2016-W11-C3/main

07ae40a

Conversation

zavfel commented Oct 6, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jeffryhartanto Oct 7, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jeffryhartanto Oct 7, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jeffryhartanto Oct 7, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jeffryhartanto commented Oct 7, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jeffryhartanto Oct 7, 2016 •

edited

Loading

jeffryhartanto Oct 7, 2016 •

edited

Loading

jeffryhartanto Oct 7, 2016 •

edited

Loading

jeffryhartanto commented Oct 7, 2016 •

edited

Loading