Open
Conversation
kychua
reviewed
Oct 7, 2016
kychua
left a comment
kychua
left a comment
There was a problem hiding this comment.
@zhijietan94 @GitMeGet @snowfeline @hongyuhy Some comments added. Please close the PR after reading comments.
- remember to acknowledge the original source of code and include a mockup of the UI in README.md
- pls tag V0.1
- make sure you've thought thought the UI - how do you plan to display deadlines and events? how are completed tasks displayed?
docs/UserGuide.md
Outdated
| Format: `add TASKNAME d/TASK_DESCRIPTION @/DATE STARTTIME ENDTIME [t/TAG...]` <br> | ||
| Format: `add TASKNAME d/TASK_DESCRIPTION @/STARTDATE ENDDATE TIME [t/TAG...]` <br> | ||
|
|
||
| \*\* <i>Refer to appendix for Possible formats for DATE & TIME</i> |
docs/UserGuide.md
Outdated
| Format: `add NAME p/PHONE_NUMBER e/EMAIL a/ADDRESS [t/TAG]...` | ||
| #### Adding a task: `add` | ||
| Adds a floating task to DoMePlease<br> | ||
| Format: `add TASKNAME d/TASK_DESCRIPTION t/TAG...` |
There was a problem hiding this comment.
task description is compulsory? is that necessary?
docs/UserGuide.md
Outdated
| Format: `add TASKNAME d/TASK_DESCRIPTION t/TAG...` | ||
|
|
||
| Adds a deadline to DoMePlease<br> | ||
| Format: `add TASKNAME d/TASK_DESCRIPTION @/DATE TIME [t/TAG...]` |
docs/UserGuide.md
Outdated
| * Edit the 2nd floating task in DoMePlease. Example Buy Pencil. | ||
| * The format whereby the 2nd floating task was entered by user in the past will be populated on the command line. | ||
| * `add Buy pencil d/Pencil to shade OAS sheet` <br> | ||
| * User will edit the inputs accordingly and submit the edit field. |
There was a problem hiding this comment.
This means the user enters 'edit 2', enter, then makes the changes? If so, user takes multiple steps, and might take a lot of time to edit if say, the user wants to edit something near the end. Is it possible to make edit easier to use? e.g. allowing user to edit a field directly
docs/UserGuide.md
Outdated
|
|
||
| #### Navigating through Calendar: `select` | ||
| Populate the list of deadlines and events on the input DATA of current month on the calendar panel <br> | ||
| Format: `select DATE` |
There was a problem hiding this comment.
consider shorter commands e.g. view to reduce amount of typing by users
docs/UserGuide.md
Outdated
|
|
||
| Examples: | ||
| * `select 5` <br> | ||
| * Assume that the calendar panel on the application is on the month of June. |
docs/UserGuide.md
Outdated
| * Output the full list of deadlines on the day and events that start, ends or is on-going on 5th June. | ||
|
|
||
| #### Deleting a task : `delete` | ||
| Deletes the specified task from DoMePlease. Irreversible <br> |
There was a problem hiding this comment.
irreversible meaning undo doesn't work on delete?
Merge show-save branch
Merge extend-undo-command branch
updated format of AboutUs.md
…dBox.fxml, PersonListCard.fxml and PersonCard.java
Merge sampledata branch
change online help to offline command summary
refactor code quality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.