[Jacob-109] iP by Jacob-109 · Pull Request #234 · nus-cs2103-AY2021S2/ip

Jacob-109 · 2021-01-28T12:48:13Z

The intended commits are those done on 21Jan 2021, i wanted to edit Level 3 but in the end it duplicated the commits above as well. I should have fixed the issue already. Sorry for the inconvenience caused if you saw the extra commits.

This reverts commit 5b6adf0.

This reverts commit 0e6d2c7.

litone01

Keep it up Jacob! You can do it:)

litone01 · 2021-02-02T10:03:16Z

src/main/java/Deadline.java

@@ -0,0 +1,14 @@
+public class Deadline extends Task {


Should the class be added or grouped inside a package? This applies to other classes as well.

litone01 · 2021-02-02T12:04:32Z

src/main/java/Duke.java

+        Scanner sc = new Scanner(System.in);
+        ArrayList<Task> list = new ArrayList<>();
+
+        while(sc.hasNext()) {


Will it be better to abstract and break this method into many smaller units? It will help in the future also.

litone01 · 2021-02-02T12:05:27Z

src/main/java/Duke.java

+import java.util.Scanner;
+import java.util.ArrayList;
+
 public class Duke {


Will it be better to add javadoc to all public classes and methods? The same applies to all other public classes and methods.

litone01 · 2021-02-02T12:07:38Z

src/main/java/Duke.java

@@ -1,10 +1,75 @@
+import java.lang.reflect.Array;


Can I check if this import is being used? Because Array should be present by default in Java.

chewwh09

Name convention could have been better overall and some nitpicking.

chewwh09 · 2021-02-05T16:36:04Z

src/main/java/Deadline.java

@@ -0,0 +1,14 @@
+public class Deadline extends Task {
+
+    protected String by;


You could have a better convention such as dateTime. "by" alone doesn't have any meaning.

so sorry I thought this was my iP, please ignore my replies if any:)

chewwh09 · 2021-02-05T16:40:16Z

src/main/java/Duke.java

                + "|____/ \\__,_|_|\\_\\___|\n";
        System.out.println("Hello from\n" + logo);
+        Scanner sc = new Scanner(System.in);
+        ArrayList<Task> list = new ArrayList<>();


Should be lists instead of list. Also, the naming convention could have been better, perhaps using tasks is better? After all, your code is being read by many people with different backgrounds. So it would be better if your naming convention is clearer.

chewwh09 · 2021-02-05T16:41:31Z

src/main/java/Event.java

@@ -0,0 +1,14 @@
+public class Event extends Task {
+
+    protected String datetime;


Your deadline by naming convention should have followed this format as well.

chewwh09 · 2021-02-05T16:43:17Z

src/main/java/Duke.java

+
+        while(sc.hasNext()) {
+            String word = sc.nextLine();
+            if (word.equals("bye")) {


You can change the if-else to switch case for better readability.

chewwh09 · 2021-02-05T16:47:33Z

src/main/java/Duke.java

+            } else if (word.equals("list")) {
+                int size = list.size();
+                System.out.println("Here are the tasks in your list:");
+                for (int i = 1; i <= size; i++) {


Could have just do for (int i = 1; i <= list.size(); i++)

chewwh09 · 2021-02-05T16:49:31Z

src/main/java/Duke.java

+
 public class Duke {
-    public static void main(String[] args) {
+    public static void main(String[] args) throws DukeException{


You should catch the DukeException, if not your program would stop running due to the exception.

chewwh09 · 2021-02-05T16:50:38Z

src/main/java/Task.java

+        this.isDone = false;
+    }
+
+    public String getStatusIcon() {


It seems like getStatusIcon() is used in this task class only, hence you can change public to private.

Jacob-109 added 12 commits January 21, 2021 13:59

Level 1.Greet,Echo,Exit

271e2f4

Level 2.Add,List

9522d74

Level 3.Mark as Done

082e99c

Level 4. ToDos, Events, Deadlines

56d2f18

Level 4. ToDos, Events, Deadlines

5b6adf0

Revert "Level 4. ToDos, Events, Deadlines"

0e6d2c7

This reverts commit 5b6adf0.

Revert "Revert "Level 4. ToDos, Events, Deadlines""

b4d0ca6

This reverts commit 0e6d2c7.

Level4.ToDos, Events, Deadlines

91ba5b7

Level4.ToDos, Events, Deadlines

28f54b8

Level5.Handle Errors

44c3b6d

Level6.Delete

81367c5

A-TextUiTesting

7e03915

Jacob-109 force-pushed the master branch 2 times, most recently from e348e78 to 7e03915 Compare January 28, 2021 13:29

Jacob-109 changed the title ~~CS2103T Project Week 2~~ [Jacob-109] iP Feb 1, 2021

litone01 reviewed Feb 2, 2021

View reviewed changes

chewwh09 reviewed Feb 5, 2021

View reviewed changes

Jacob-109 added 13 commits February 10, 2021 00:03

Level-7

3166da9

Level-8

436656a

Merged branch 'branch-Level-7'

5a03f8f

Merged Branch-level-8 into master branch

5220f22

Fixed bug that caused Task to not be load properly

14de94b

add oop

0305fd6

add JUnit test for Deadline and TaskList

9d38c53

add Level-9.Find command

76fb6d6

add JavaDocs

9337ccb

add CodingStandard

7301499

add A-Gradle and Assertions

d7889df

add A-CodeQuality

bf4797e

added C-Tagging for ToDo

05a3f62

Jacob-109 added 10 commits February 28, 2021 10:43

added Assertions

c2d76ad

Added GUI

7d82d76

Added UserGuide

04b7f4d

Fixed bugs in Gradle and Duke

f8c8bea

Fixed Bugs and Checkstyle

876e9ec

Added Ui.png

08f29a1

Modifications to Project to Structure

a82c13b

Modifications to Class Files and GUI

6cbdfba

Updated MANIFEST and README

4211cd9

Cleaned up .class files and fixed Parser.java

afe7462

		@@ -0,0 +1,14 @@
		public class Deadline extends Task {

		protected String by;

		@@ -0,0 +1,14 @@
		public class Event extends Task {

		protected String datetime;

Conversation

Jacob-109 commented Jan 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

litone01 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chewwh09 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Jacob-109 commented Jan 28, 2021 •

edited

Loading