[Sunaga] iP by nowknowing · Pull Request #240 · nus-cs2103-AY2021S2/ip

nowknowing · 2021-01-29T07:50:14Z

No description provided.

- added DONE and Task object

…one.

Add input and expected

Added 3 exceptions extending Duke Exception Persisting issue: blank line / space input does not give IDK exception.

Add delete aaaa / done aaaa exception handler as invalid.

…g to each DukeException child class.

…pdate task in taskList.

w2vgd

Code is easy to read overall 👍 I have noted a few coding standard violations.

w2vgd · 2021-02-01T16:09:25Z

src/main/java/duke/Duke.java

+
+
+    private void processInput(String userInput) {
+        String keyword_UC = userInput.toUpperCase().split(" ", -1)[0];


Perhaps use a camelCase variable name and a more descriptive name rather than UC here?

w2vgd · 2021-02-01T16:18:34Z

src/main/java/duke/Duke.java

+import duke.exceptions.DukeMissingDesException;
+import duke.handler.Parser;
+import duke.handler.Queries;
+import duke.tasks.*;


Should this import statement be listed explicitly instead?

w2vgd · 2021-02-01T16:19:01Z

src/main/java/duke/Duke.java

+import duke.tasks.*;
+import duke.tasks.Event;
+
+import java.awt.*;


Same issue as above

w2vgd · 2021-02-01T16:20:42Z

src/main/java/duke/Storage.java

+import java.util.Scanner;
+
+public class Storage {
+    private static String STORAGE_PATH;


Perhaps this instance variable should be declared final instead? (as your variable name is already in all uppercase letters)

w2vgd · 2021-02-01T16:24:06Z

src/main/java/duke/Ui.java

+    }
+
+    public String readCommand() {
+        assert hasCommand();


Like the use of assertion here 😄

w2vgd · 2021-02-01T16:26:20Z

src/main/java/duke/exceptions/DukeException.java

@@ -0,0 +1,14 @@
+package duke.exceptions;
+
+public class DukeException extends Exception{


Should there be a space between Exception and the opening bracket {?

w2vgd · 2021-02-01T16:28:52Z

src/main/java/duke/exceptions/DukeIDKException.java

@@ -0,0 +1,23 @@
+package duke.exceptions;
+
+public class DukeIDKException extends DukeException{


Should there be a space between DukeException and the opening bracket {?
I noticed the same issue in several other places too.

w2vgd · 2021-02-01T16:37:34Z

src/main/java/duke/tasks/Task.java

+    }
+
+    public Task markDone() {
+        this.isDone = true;


Perhaps you can remove the unnecessary this here?

w2vgd · 2021-02-01T16:39:16Z

src/main/java/duke/tasks/Task.java

+        this.type = type;
+    }
+
+    public Task markDone() {


Should this method be named differently because markDone does not really tell us that a task will be returned?

w2vgd · 2021-02-01T16:40:19Z

src/main/java/duke/tasks/TaskList.java

+
+
+    public TaskList() {
+        this.tasks = new ArrayList<>();


Perhaps remove the redundant this here?

cnlinh

Overall clear and well-formatted code but some parts can be further abstracted for clarity.

cnlinh · 2021-02-02T11:39:44Z

src/main/java/duke/Duke.java

+import java.util.Scanner;
+
+public class Duke {
+    private boolean exit = false;


cnlinh · 2021-02-02T11:40:03Z

src/main/java/duke/Duke.java

+    }
+
+    public static void main(String[] args) throws IOException {
+        new Duke("data/tasks.txt").run();


You may want to use relative path

Hi my understanding was that this already is a relative path.
What do you mean by use a "relative path"? could you suggest how this is done? Thank you.

cnlinh · 2021-02-02T11:40:47Z

src/main/java/duke/Duke.java

+                break;
+
+            case ADD:
+                Task toAdd;


You may want to abstract each case into a separate method

cnlinh · 2021-02-02T11:42:35Z

src/main/java/duke/handler/Parser.java

+
+public class Parser {
+    public static Task parseFromData(String dataInput) {
+        String[] splitInput = dataInput.split("\\|", -1);


splitInputs?

cnlinh · 2021-02-02T11:44:13Z

src/main/java/duke/exceptions/DukeIDKException.java

+    /**
+     * Constructor for DukeException for incomprehensible request.
+     */
+    public DukeIDKException() {


DukeIdkException?

…ePossible method in Duke. (easy way out). Change ADD to TODO/DEADLINE/EVENT in Queries.

Add TaskHandler absrtact class.

Improve CodeQuality

# Conflicts: # src/main/java/duke/handler/DeadlineHandler.java # src/main/java/duke/handler/EventHandler.java # src/main/java/duke/handler/TodoHandler.java

Add assert to getTask method

Format requires Schedule weekly (no.of times) (schedulable event). Issue: listing does not work beyond 7 tasks when queried as after 1st query.

Debug

Add Ui.png screenshot

Change app name to remove space

damithc and others added 22 commits July 23, 2020 23:27

Add Gradle support

3b19ba1

build.gradle: Update version to 8.29

a75fcee

Editted/added intro display

a47d697

Level 1 Greet, Echo, Exit

868d263

Level 2 Add,List

40da541

Level 2 compiled

f7a9485

Level 3 - Mark as Done (with tick)

5c1e2d7

- added DONE and Task object

Editted to not list every time something is done. Only show what is d…

277ea31

…one.

removed Tasks class

286f0e6

Level 4 - todo,events,deadlines

3c427af

Change tick to Cross

6d87412

Add input and expected

Edit full path to FC

217f18d

Edit Formats at expected and boxes.

2da7257

Added 3 exceptions extending Duke Exception Persisting issue: blank line / space input does not give IDK exception.

Add Delete Method.

7ce01bc

Add delete aaaa / done aaaa exception handler as invalid.

Combine exceptions handling. i.e. clean up

5ea0390

Add Ui class in charge of reading and writing. Moved exception handin…

83e25ad

…g to each DukeException child class.

Edit Duke to remove Ui redundancies.

a92c7bf

Add relevant packaging. remove .class

bbed8dd

Add TaskList

2d4fffb

Reading from storage only. Add Parser and Storage class

a97bea5

Cleanup Duke. Add Storage read. Edit parser from 0 to X.

8edf5a9

Gettable in task child classes. New info of task type. Markdone and u…

83214d0

…pdate task in taskList.

w2vgd reviewed Feb 1, 2021

View reviewed changes

nowknowing added 3 commits February 2, 2021 10:17

Update Storage to markdone, delete, add new events.

b1c6137

Empty parse from input method in Parser.java

8060ea0

Merge branch 'branch-Level-7'

02d7dde

cnlinh reviewed Feb 2, 2021

View reviewed changes

nowknowing added 3 commits February 2, 2021 21:30

Add DateTime. Add DukeDateTimeException. Complete Level 8

82e1692

Merge branch 'branch-Level-8'

1cb4a2c

Add Handler. Edit Parser such that it only parses. Add checkDeleteDon…

d81a8ac

…ePossible method in Duke. (easy way out). Change ADD to TODO/DEADLINE/EVENT in Queries.

nowknowing and others added 30 commits February 12, 2021 17:48

Merged gradle branch. Changed mainclassName.

f839ecc

Add Checkstyle. Edit code to meet standards.

d0fd76b

Add Gui. Level-10

6b9e7ba

Merge branch 'branch-Level-10'

2506408

Add Checkstyle-IDEA plugin and fixes.

1d9c26a

Made fat JAR

7d6099f

Improve codeQuality

1c411b5

Add TaskHandler absrtact class.

Remove assert.

ec1cf9c

Add assert to getTask method

1e1920d

Merge pull request #2 from nowknowing/Branch-A-CodeQuality

f6bdb5f

Improve CodeQuality

Merge branch 'master' into branch-A-Assertions

7221b25

# Conflicts: # src/main/java/duke/handler/DeadlineHandler.java # src/main/java/duke/handler/EventHandler.java # src/main/java/duke/handler/TodoHandler.java

Assert methods to getTask.

a577fa0

Merge pull request #3 from nowknowing/branch-A-Assertions

1a5be77

Add assert to getTask method

Allow weekly recurring tasks for deadline and event.

e532b61

Format requires Schedule weekly (no.of times) (schedulable event). Issue: listing does not work beyond 7 tasks when queried as after 1st query.

Delete Ui.

8dad726

Merge branch 'branch-RecurringTasks'

10f881f

Improve GUI

7ece23f

Change schedule input format.

d507f93

Debug

Delete data

4a8e6c8

Add title Duke Luke Muke.

c1e705b

Add Ui.png screenshot

Add Readme UseGuide

df8672a

Change app name to remove space

Set theme jekyll-theme-modernist

cc86996

New release

25557d1

Merge branch 'master' of https://github.com/nowknowing/ip

418f1b7

Set theme jekyll-theme-slate

78d7172

Add release hyperlink in readme.

ab50e57

Update intro page README

f43eca3

Add pause.

123ad30

New version

6c56882

Update readme link

1cd8274



		private void processInput(String userInput) {
		String keyword_UC = userInput.toUpperCase().split(" ", -1)[0];

		@@ -0,0 +1,14 @@
		package duke.exceptions;

		public class DukeException extends Exception{

		@@ -0,0 +1,23 @@
		package duke.exceptions;

		public class DukeIDKException extends DukeException{

Conversation

nowknowing commented Jan 29, 2021

Uh oh!

w2vgd left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cnlinh left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants