[Jared Lim] iP by jared98lyj · Pull Request #276 · nus-cs2103-AY2021S2/ip

jared98lyj · 2021-02-06T13:24:50Z

No description provided.

Added ArrayList to store input.

Improved layout of code. Added children classes for task to give more granularity to the different types of tasks.

Added try-catch blocks to flag errors, and prevent possible incorrect input from created unwanted stops/breakages in the program.

Added the removeTask method for deletion

justgnohUG · 2021-02-06T16:43:50Z

src/main/java/Duke.java

+
+    /**
+     * Main class to take in user input.
+     * @param args Filler


Perhaps a more meaningful name for @param could be possibly replaced here

justgnohUG · 2021-02-06T16:56:16Z

src/main/java/Event.java

+    }
+
+    /**
+     * Overriden constructor to account for deadline and events that have timestamps.


Not too sure if "Overriden" is the appropriate term here. I think "Overloaded constructor" may be more appropriate.

justgnohUG · 2021-02-06T16:56:45Z

src/main/java/Duke.java

+    }
+
+    /**
+     * Enumerates all tasks in the lis using 1-based indexing.


Minor typo for "list"

justgnohUG · 2021-02-06T17:06:23Z

src/main/java/Task.java

+     * @param description Description of method
+     * @param eventDate Boolean flag indicating whether task is done
+     */
+    public Task(String description, String eventDate) {


Might be a good idea to add "@OverRide" tag if this method is truly overriden

Added I/O utility. Autocreate data directory if it does not exist.

wei-yutong

your code is generally very clean and easy to read! i liked how your method names were clear and how you separated long lines accurately :)

wei-yutong · 2021-02-07T03:41:30Z

src/main/java/Duke.java

+/**
+ * Driver class that takes in input and performs certain functions based on input.
+ */
 public class Duke {


this class is rather long, perhaps you could consider abstracting the methods out?

wei-yutong · 2021-02-07T03:42:42Z

src/main/java/Duke.java

+            } else if (command.equals("list")) {
+                enumerateTasks();
+            } else if (command.startsWith("done")) {
+                String[] delString = command.split("\\s+");


delString is not a very intuitive variable name, maybe you could make it more specific?

wei-yutong · 2021-02-07T03:49:35Z

src/main/java/Event.java

+    }
+
+    /**
+     * Overriden constructor to account for deadline and events that have timestamps.


i think the term you meant to use might be "overloaded" instead

wei-yutong · 2021-02-07T03:53:52Z

src/main/java/Task.java

+        low,
+        average,
+        high


I think that constants in enum should be in all uppercase, eg "LOW", "AVERAGE" and "HIGH"

wei-yutong · 2021-02-07T03:55:08Z

src/main/java/Task.java

+    }
+
+    /**
+     * Overriden method to mark a task as done.


Did you mean "Overloaded" here as well? I've noticed it in a few other places. Otherwise, as the other reviewer mentioned, overridden methods should tagged with "@OverRide"

Added date time formatter across all task classes. Created a ParseDate class to handle date formatting.

Add-gradle-support Included J-unit tests under dependencies in build.gradle file Added gradle wrapper files as well

Added a find function uitlity to filter tasks by keyword

Refactored a bulk of the code from Duke.java into four classes: Parser, Storage, TaskList, and Ui. Modified Duke.java to accomodate these changes as well.

Included the gradle wrapper and the associated dependencies for the Junit test. Added two JUnit Test: One to test the loading of the stored text file, the other to test marking as done utility. Both under src/test/java.

Applied changes to all other dependent classes as well.

Added GUI and modified the corresponding methods to return a string (rather than stdout) to feed into the user input functions, which are returned and displayed in the dialogue box in GUI.

…checks for non empty objects, and list to avoid unchecked null pointers which can crash the program.

…s as much as possible by abstracting it away into the Task classes.

…ption to specify type of search: partial case sensitive, partial non- case sensitive, full exact match.

GUI echoes user commands, returns output by bot.

…output

…methods which are quite clear.

…method body. Prevented as much as possible the use of magic strings when it comes to important kinds of data. Avoided direct usage of list indexing in Duke method by abstracting to the TaskList method.

…nsistencies for specific inputs like missing spaces.

This reverts commit 518584e.

jared98lyj added 7 commits February 5, 2021 00:13

Added the driver function to take in user input.

d3163e8

Added ArrayList to store input.

Level 2

d4a6722

Updated to level 3.

fe3ca81

Level-4

5039c1a

Improved layout of code. Added children classes for task to give more granularity to the different types of tasks.

Level-5

da14f03

Added try-catch blocks to flag errors, and prevent possible incorrect input from created unwanted stops/breakages in the program.

Level-6

0de7bcb

Added the removeTask method for deletion

Renamed to Duke.java

5da5f47

jared98lyj changed the title ~~Updated till level 6.~~ [Jared Lim] IP Feb 6, 2021

jared98lyj changed the title ~~[Jared Lim] IP~~ [Jared Lim] iP Feb 6, 2021

justgnohUG reviewed Feb 6, 2021

View reviewed changes

src/main/java/Duke.java Outdated

}

/**

* Enumerates all tasks in the lis using 1-based indexing.

Copy link

justgnohUG Feb 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo for "list"

justgnohUG reviewed Feb 6, 2021

View reviewed changes

Level-7

77d1af0

Added I/O utility. Autocreate data directory if it does not exist.

wei-yutong reviewed Feb 7, 2021

View reviewed changes

jared98lyj added 15 commits February 10, 2021 23:59

Level-8

18fefbf

Added date time formatter across all task classes. Created a ParseDate class to handle date formatting.

A-J-Unit

c8a2318

Add-gradle-support Included J-unit tests under dependencies in build.gradle file Added gradle wrapper files as well

Level-9

1304374

Added a find function uitlity to filter tasks by keyword

A-MoreOOP

4f24e1a

Refactored a bulk of the code from Duke.java into four classes: Parser, Storage, TaskList, and Ui. Modified Duke.java to accomodate these changes as well.

Add JUnit Tests

1840dd9

Included the gradle wrapper and the associated dependencies for the Junit test. Added two JUnit Test: One to test the loading of the stored text file, the other to test marking as done utility. Both under src/test/java.

Made the classes more OOP-like.

0ea2605

Applied changes to all other dependent classes as well.

Level-10

32edbd5

Added GUI and modified the corresponding methods to return a string (rather than stdout) to feed into the user input functions, which are returned and displayed in the dialogue box in GUI.

Added important assertions throughout the code. Some of them include …

14600d2

…checks for non empty objects, and list to avoid unchecked null pointers which can crash the program.

Improved abstration in the Duke.java, erasing direct array/list acces…

03647c1

…s as much as possible by abstracting it away into the Task classes.

Improved the find function to be more flexible, giving the user the o…

e7ef799

…ption to specify type of search: partial case sensitive, partial non- case sensitive, full exact match.

Built a basic GUI for interaction betwen user and bot.

e1e5628

GUI echoes user commands, returns output by bot.

Added a simple user guide with some usage examples and corresponding …

51aa8fe

…output

Added java doc comments for most methods, less the getter and setter …

bf88b10

…methods which are quite clear.

Improved code quality by ensuring similar levels of abstraction in a …

0f29c67

…method body. Prevented as much as possible the use of magic strings when it comes to important kinds of data. Avoided direct usage of list indexing in Duke method by abstracting to the TaskList method.

Refactored CLI version of Duke.java.

f81b02a

jared98lyj and others added 17 commits February 19, 2021 20:58

Improved consistency of String representation and formatting.

507b9d7

Added input and expected text to the files. Debugged some of the inco…

677fc36

…nsistencies for specific inputs like missing spaces.

Fixed launching issues with duke.jar file.

9949574

Made final changes to the readMe file and added a background image.

1b8b269

Update README.md

e874003

Delete README.md

95b3b38

Updated minor changes to UI class.

d6ece15

Set theme jekyll-theme-slate

7207a74

Commtting the Ui.png file to docs directory

518584e

Revert "Commtting the Ui.png file to docs directory"

b4d202a

This reverts commit 518584e.

Merge branch 'master' of https://github.com/jared98lyj/ip

64f4838

Commiting the Ui.png to docs directory

c110de9

no message

23b0d4c

Renamed image file to Ui.png

a8522c6

Renamed to Ui.png

7af6082

Update README.md

b07b0a0

Update README.md

5f828d2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Jared Lim] iP#276

[Jared Lim] iP#276
jared98lyj wants to merge 40 commits intonus-cs2103-AY2021S2:masterfrom
jared98lyj:master

jared98lyj commented Feb 6, 2021

Uh oh!

justgnohUG Feb 6, 2021

Uh oh!

justgnohUG Feb 6, 2021

Uh oh!

justgnohUG Feb 6, 2021

Uh oh!

justgnohUG Feb 6, 2021 •

edited

Loading

Uh oh!

wei-yutong left a comment

Uh oh!

wei-yutong Feb 7, 2021

Uh oh!

wei-yutong Feb 7, 2021

Uh oh!

wei-yutong Feb 7, 2021

Uh oh!

wei-yutong Feb 7, 2021

Uh oh!

wei-yutong Feb 7, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

jared98lyj commented Feb 6, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

justgnohUG Feb 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wei-yutong left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

justgnohUG Feb 6, 2021 •

edited

Loading