Conversation
yunbinmo
left a comment
yunbinmo
left a comment
There was a problem hiding this comment.
I like how you make most of the names sound straightforward and the code blocks are properly separated by empty lines!
seksek13
left a comment
seksek13
left a comment
There was a problem hiding this comment.
Overall, methods and variables had followed the naming convention, good job!
|
|
||
| public String find(String keyword) { | ||
| String resultStr = ""; | ||
| boolean keywordFound = false; |
There was a problem hiding this comment.
Boolean variable should use a prefix such as is, has, was.
src/main/java/seedu/duke/Ui.java
Outdated
| myPrint(tasks.delete(Parser.getIndex(input))); | ||
| break; | ||
| case FIND: | ||
| myPrint(tasks.find(Parser.getDescription(input))); |
There was a problem hiding this comment.
Maybe it will be better to change the myprint() method name to something that would explain the function better
| * @return String that describes the number of tasks in the TaskList | ||
| */ | ||
| public String count() { | ||
| String isSingular = "s"; |
There was a problem hiding this comment.
Why does the string variable had the prefix "is", it might be confusing for others as this prefix is reserved for boolean variables. It might be better to rename this variable :)
| tasks.add(new Event("party ", LocalDate.of(2022, 12, 12))); | ||
| tasks.add(new ToDo("borrow book")); | ||
|
|
||
| TaskList t = new TaskList(tasks); |
There was a problem hiding this comment.
is it possible to rename this variable name so that it would be clearer in showing what you are doing?
Code was messy and might be unreadable Code quality improvement helps for future reference and checking. Let's * check for error-prone practices * delete all dead code
Find command is case sensitive A case insensitive find is more user-friendly because users cannot be expected to remember the exact case of the keywords. Let's update the search algorithm to use case-insensitive matching
Branch merging pr
3 participants
DukePro
DukePro frees your mind of having to remember things you need to do. It's
FASTSUPER FAST to useAll you need to do is,
And it is FREE
Features:
If you Java programmer, you can use it to practice Java too. Here's the
mainmethod: