[Edward Alvin] ip #294
Open
[Edward Alvin] ip #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckcherry23
reviewed
Feb 4, 2022
ckcherry23
left a comment
ckcherry23
left a comment
There was a problem hiding this comment.
The code thus far looks good! 👍🏼
Just some suggestions and nits to fix.
Comment on lines
+37
to
+63
| public static void processInput(InputType inputType, String[] value) { | ||
| switch(inputType) { | ||
| case LIST: | ||
| wordList.printList(); | ||
| break; | ||
| case MARK: | ||
| wordList.markItem(Integer.parseInt(value[0])); | ||
| break; | ||
| case UNMARK: | ||
| wordList.unmarkItem(Integer.parseInt(value[0])); | ||
| break; | ||
| case TODO: | ||
| wordList.storeTodo(value[0]); | ||
| break; | ||
| case DEADLINE: | ||
| wordList.storeDeadline(value[0], value[1]); | ||
| break; | ||
| case EVENT: | ||
| wordList.storeEvent(value[0], value[1]); | ||
| break; | ||
| case BYE: | ||
| replyBye(); | ||
| break; | ||
| case NONE: | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
The coding standard for this module requires no indentation for the case clauses under switch! Perhaps you can configure your IDE to follow this new standard by default.
| @@ -0,0 +1,17 @@ | |||
| public enum InputType { | |||
| @@ -0,0 +1,14 @@ | |||
| public class Deadline extends WordListItem{ | |||
There was a problem hiding this comment.
Suggested change
| public class Deadline extends WordListItem{ | |
| public class Deadline extends WordListItem { |
Be careful with the spacing requirements for Egyptian style brackets!
Comment on lines
+55
to
+67
| @Override | ||
| public String toString() { | ||
| int i = 1; | ||
| String str = ""; | ||
| str += "------------------------------------\n"; | ||
| for(WordListItem wordListItem: this.wordList) { | ||
| str += i + ". " + wordListItem + "\n"; | ||
| i++; | ||
| } | ||
| str += "------------------------------------\n"; | ||
| return str; | ||
| } | ||
| } |
There was a problem hiding this comment.
I think you can make use of the toString() method of WordListItem directly in printList(), instead of returning a complicated String expression here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.