[Edward Alvin] ip #305

ThePrevailingOne · 2022-01-30T08:44:29Z

No description provided.

…dline, and Event

[Edward Alvin] Create Duke Skeleton, ip

Add new Exceptions for basic invalid inputs

geraldneo567 · 2022-02-02T14:23:45Z

src/main/java/Duke.java

-        return Duke.LIST.equals(word);
+    public static void processInput(InputType inputType, String value) {
+        switch(inputType) {
+            case LIST:


According to the codestyle, there should be no intentation for 'case' clauses in the switch block.

geraldneo567 · 2022-02-02T14:24:05Z

src/main/java/Duke.java

-    public static boolean isList(String word) {
-        return Duke.LIST.equals(word);
+    public static void processInput(InputType inputType, String value) {
+        switch(inputType) {


Minor style-related thing, but there should be a space before the bracket i.e switch (inputType)

geraldneo567 · 2022-02-02T14:25:17Z

src/main/java/Duke.java

            Object[] parseResult = InputParser.parseInput(input);
            InputType inputType = (InputType) parseResult[0];
-            String value = (String) parseResult[1];
+            String[] value = (String[]) parseResult[1];


Why the cast to String[] array here, instead of making InputParser::parseInput(input) return a String[] instead of Object[]?

geraldneo567 · 2022-02-02T14:26:11Z

src/main/java/InputParser.java

-                value = "";
-                if (inputType.label.length() < input.length()) {
-                    value = input.substring(inputType.label.length() + 1);
+                if (inputType == InputType.BYE || inputType == InputType.LIST) {


Maybe it would be neater to separate out into boolean variables for example isBye, isList, etc to be in line with the code quality guideline

muraddurrani

Generally I found it quite easy to read all the code. I think you just need to adjust some small things like renaming arrays and arraylists to be plural form.

muraddurrani · 2022-02-03T14:19:16Z

src/main/java/Duke.java

+                Object[] parseResult = InputParser.parseInput(input);
+                InputType inputType = (InputType) parseResult[0];
+                String[] value = (String[]) parseResult[1];


I think parseResult and value could both be renamed in plural form (results and values perhaps?) to be consistent with naming conventions. I noticed this in a few other places.

muraddurrani · 2022-02-03T14:24:39Z

src/main/java/Duke.java

+        }
+    }
+
+    public static void processInput(InputType inputType, String[] value) {


Small thing because its just a parameter but maybe change value to values so its plural?

muraddurrani · 2022-02-03T14:27:05Z

src/main/java/Todo.java

@@ -0,0 +1,12 @@
+public class Todo extends WordListItem{


I think there should be a space between WordListItem and {.

muraddurrani · 2022-02-03T14:27:27Z

src/main/java/UnknownInputException.java

@@ -0,0 +1,5 @@
+public class UnknownInputException extends Exception{


I think there should be a space between Exception and {.

muraddurrani · 2022-02-03T14:27:51Z

src/main/java/WordList.java

+import java.util.ArrayList;
+
+public class WordList {
+    private ArrayList<WordListItem> wordList;


Perhaps this could be renamed to words or something similar to be plural?

muraddurrani · 2022-02-03T14:28:33Z

src/main/java/WordList.java

+        System.out.println(this);
+    }
+
+    public int length() {


The coding standards suggest that method names be verbs. Perhaps this could be changed to getLength or something like that.

…efactor the rest of the code

The sort command does not exist yet. The sort command allows more functionality for the user which will come really handy. Let's, * create the sort, sortevent, and sortdeadline command in inputtype * update the inputparser and wordlist to adjust

ThePrevailingOne · 2022-03-01T15:56:30Z

Duked

“Your mind is for having ideas, not holding them.” – David Allen

Duked frees your mind of having to remember things you need to do. It's,

text-based
easy to learn
~~FAST~~ SUPER FAST to use

All you need to do is,

download it from here.
double-click it.
add your tasks.
let it manage your tasks for you 😉

And it is FREE!

Features:

Managing tasks
Managing deadlines (coming soon)
Sorting tasks (coming soon)

Just double click on the jar and it should open the app GUI :)

or

Run

java -jar Duke.jar //depending on the relative location of the app

damithc and others added 15 commits July 29, 2021 20:30

Add Gradle support

d839859

Create an echo() and replyBye() method for Duke

43b3d55

Add welcome message for Duke

319056f

Implement word list into Duke

0688e25

Implement marking/unmarking of word list in Duke

53466c7

Refactor word list into its own class

be0072b

Create class Todo, Deadline, and Event

e8e1092

Refactor code using InputType enum and an InputParser

a4f0552

Refactor Duke with processInput() and move sout() statements to WordList

b0bfa54

Hotfix minor bug in InputParser

4dcb935

Refactor and adjust WordList as well as Duke to adjust with Todo, Dea…

888a7b8

…dline, and Event

Merge pull request #1 from ThePrevailingOne/skeleton

94995b9

[Edward Alvin] Create Duke Skeleton, ip

Add new Exceptions for basic invalid inputs

28a9832

Merge pull request #2 from ThePrevailingOne/exception-handling

5aa3725

Add new Exceptions for basic invalid inputs

Merge branch 'master' of github.com:ThePrevailingOne/ip

14e2a6a

geraldneo567 reviewed Feb 2, 2022

View reviewed changes

muraddurrani reviewed Feb 3, 2022

View reviewed changes

ThePrevailingOne added 10 commits February 7, 2022 22:54

Implement saving system using org.json, Create JSONFileManager, and R…

b307f61

…efactor the rest of the code

Implement date and time with DateTime to replace String

082bd2e

Merge branch 'datetime'

f451d9f

Add more OOP DukeUI, and edit .gitignore

1e84453

Merge branch 'a-moreoop'

d93678d

Refactor into packages and fix input whitespaces

0ae6bae

Merge branch 'a-packages'

f5ac54f

Add JUnit Testing

9017932

Add Javadoc into the app

0da00b1

Implement a find feature to Duke

49667e6

ThePrevailingOne and others added 15 commits February 23, 2022 21:37

merge to add-gradle-support

0df53e3

Merge branch 'master' into add-gradle-support

06db74c

Add gradle support

61632f0

Merge branch 'add-gradle-support'

2c1ab2b

Update gradle to 7.3 and remove save file

de030de

Add JavaFX to dependencies

9701571

Add GUI

2fb2a5d

Merge branch 'JavaFx'

9cbecdf

Hotfix data/ folder and remove unused code

939b9ab

Allow user to sort the list

f2136c3

The sort command does not exist yet. The sort command allows more functionality for the user which will come really handy. Let's, * create the sort, sortevent, and sortdeadline command in inputtype * update the inputparser and wordlist to adjust

Hotfix souts

e089191

Add a user guide

6d1fe81

Set theme jekyll-theme-cayman

19b492b

Set theme jekyll-theme-slate

559e67e

Set theme jekyll-theme-cayman

3080ed8

ThePrevailingOne added 3 commits March 1, 2022 23:58

Change user guide title

941e353

Merge branch 'master' of github.com:ThePrevailingOne/ip

020089e

Change gradle version

705a92d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Edward Alvin] ip #305

[Edward Alvin] ip #305

Uh oh!

ThePrevailingOne commented Jan 30, 2022

Uh oh!

geraldneo567 Feb 2, 2022

Uh oh!

geraldneo567 Feb 2, 2022

Uh oh!

geraldneo567 Feb 2, 2022

Uh oh!

geraldneo567 Feb 2, 2022

Uh oh!

muraddurrani left a comment

Uh oh!

muraddurrani Feb 3, 2022

Uh oh!

muraddurrani Feb 3, 2022

Uh oh!

muraddurrani Feb 3, 2022

Uh oh!

muraddurrani Feb 3, 2022

Uh oh!

muraddurrani Feb 3, 2022

Uh oh!

muraddurrani Feb 3, 2022

Uh oh!

ThePrevailingOne commented Mar 1, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -0,0 +1,5 @@
		public class UnknownInputException extends Exception{

[Edward Alvin] ip #305

Are you sure you want to change the base?

[Edward Alvin] ip #305

Uh oh!

Conversation

ThePrevailingOne commented Jan 30, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

muraddurrani left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ThePrevailingOne commented Mar 1, 2022

Duked

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants