[Rena] iP #458

Chiarena · 2024-02-05T13:15:26Z

Duke

"The key is not to prioritize whats on your schedule, but to schedule your priorities." – Stephen Covey (source)

Duke helps you record your tasks and makes it easier for you to manage them.

Fast

Easy

Fun

All you need to do is,

download it from here.
double click it.
add your tasks.
let it manage your tasks for you 😉.

And it is FREE!

Features:

Adding, deleting, marking tasks
Manage todo, deadlines and events
View list of tasks and find tasks

If you are a Java programmer, you can use it to practice Java too. Here's tje main method:

public class Main {
    public static void main(String[] args) {
        Application.launch(MainApp.class, args);
    }
}

Let's tweak the docs/README.md (which is used as the user guide) to fit Duke better. Specifically, 1. mention product name in the title 2. mention adding a product screenshot and a product intro 3. tweak the flow to describe feature-by-feature

NewtonKoh

LGTM. Small nits only

NewtonKoh · 2024-02-10T10:20:48Z

src/main/java/Duke.java

+                    } else if (message.startsWith("unmark")){
                        current.unmark();
                        System.out.println(printMark(current));
+                    }else{


I think you may have forgotten to add a space before and after the 'else' here.

cocoanautz

Just some nits that require attention, mainly related to coding standards and naming.

cocoanautz · 2024-02-11T07:32:36Z

src/main/java/Duke.java

Could probably store the lines as a constant value to make the code easier to change.

cocoanautz · 2024-02-11T07:33:31Z

src/main/java/Duke.java

+                "____________________________________________________________\n";
+    }
+
+    public static ArrayList<Task> delete(ArrayList<Task> a, int count) {


The method name could be changed to explain more about what this method is deleting.

cocoanautz · 2024-02-11T07:33:54Z

src/main/java/Duke.java

+        Scanner input = new Scanner(System.in);
+        System.out.println("Enter Message");
+
+        final int ArraySize = 100;


Constants should be in screaming_snake_case.

cocoanautz · 2024-02-11T07:35:41Z

src/main/java/Duke.java

+                        String task = getTask(message);
+                        String[] parts = time.split("by");
+//                        tasks[counter] = new Deadline(task, parts[1]);
+                        tasks.add(new Deadline(task, parts[1]) );


Suggested change

tasks.add(new Deadline(task, parts[1]) );

tasks.add(new Deadline(task, parts[1]));

cocoanautz · 2024-02-11T07:36:45Z

src/main/java/Duke.java

+        }
+    }
+
+    public static String added(Task task, int count) {


Suggested change

public static String added(Task task, int count) {

public static String printAdded(Task task, int count) {

Methods should have verbs as names.

HusseinSafwan02

Some syntax issues to fix, as well as naming conventions, but well done so far!

HusseinSafwan02 · 2024-02-13T04:58:34Z

src/main/java/DataManager.java

+        String status = " ";
+        if(task instanceof Todo) {
+            symbol = "T";
+        }else if(task instanceof Deadline) {


could insert a space between } and else if

HusseinSafwan02 · 2024-02-13T05:00:44Z

src/main/java/Duke.java

+                    if (message.startsWith("todo")) {
+                        String[] parts = message.split(" ", 2);
+                        String task = parts[1];
+//                        tasks[counter] = new Todo(task);


consider removing these comments once code is finalised :)

# Conflicts:conflict in Duke.java # src/main/java/Duke/Duke.java

# Conflicts: Conflicts between level-9 and master branches # src/main/java/Duke/Duke.java # src/main/java/actions/Parser.java # src/main/java/actions/TaskList.java

Introduced assertions in the Parser class for handle methods to validate assumptions about method inputs. This enhances debugging and code reliability during development.

Arrow head code is reduced These changes enhance maintainability and readability of the code

Add critical assertions across to the parser class

CodeQuality

damithc and others added 12 commits January 7, 2024 18:33

docs/README.md: Tweak document template

55f9f9f

Let's tweak the docs/README.md (which is used as the user guide) to fit Duke better. Specifically, 1. mention product name in the title 2. mention adding a product screenshot and a product intro 3. tweak the flow to describe feature-by-feature

Add Gradle support

f837ddb

Bump gradle and lib version

a6f7324

Level 0-1

e038c80

Level 1-2

ec99ab5

level 2 done

8bf1856

Added level 3

0b4044d

Added level 4 - deadline,todo,event

bfe14f0

added functions

beff8a4

Automated testing done

3103d89

Exceptions class added

52770ed

Delete function added

e65d1c3

This comment was marked as off-topic.

Sign in to view

NewtonKoh reviewed Feb 10, 2024

View reviewed changes

cocoanautz reviewed Feb 11, 2024

View reviewed changes

Added save feature

c9ede7f

HusseinSafwan02 reviewed Feb 13, 2024

View reviewed changes

Chiarena added 13 commits February 18, 2024 16:22

date time added

7c7eb0f

oop done

a45e142

Classes arranged into packages

cecd03d

Merge remote-tracking branch 'origin/add-gradle-support'

396cf5c

isExit corrected

11e9506

corrected bye command to terminate program

f829900

JUnit tests added

89331f7

java docs added

4459683

removed redundant code

61137a6

Find feature added

eb8604d

Coding standard improved

c1110ed

Merge branch 'branch-A-JavaDoc'

e785e0e

# Conflicts:conflict in Duke.java # src/main/java/Duke/Duke.java

Merge branch 'branch-A-CodingStandard'

fca0a8a

Chiarena and others added 14 commits February 26, 2024 12:15

Merge branch 'branch-Level-9'

b21992a

# Conflicts: Conflicts between level-9 and master branches # src/main/java/Duke/Duke.java # src/main/java/actions/Parser.java # src/main/java/actions/TaskList.java

further corrected code after merging

1f9dfe6

Add critical assertions across to the parser class

96ec174

Introduced assertions in the Parser class for handle methods to validate assumptions about method inputs. This enhances debugging and code reliability during development.

The code for each class is edited and sectioned to improve code quality

d8808e1

Arrow head code is reduced These changes enhance maintainability and readability of the code

Merge pull request #3 from Chiarena/branch-A-Assertions

a7c37b3

Add critical assertions across to the parser class

Merge branch 'master' into branch-CodeQuality

ed78efc

Merge pull request #2 from Chiarena/branch-CodeQuality

1fa1a03

CodeQuality

update feature added

222176b

Update README.md

f075d9c

README edited

14682ee

Added user guide

0daaeec

JavaFX

a8872c7

Merge branch 'branch-Level-10'

774cdc7

JavaFX edited

b3794f2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Rena] iP #458

[Rena] iP #458

Uh oh!

Chiarena commented Feb 5, 2024 •

edited

Loading

Uh oh!

This comment was marked as off-topic.

Uh oh!

NewtonKoh left a comment

Uh oh!

NewtonKoh Feb 10, 2024

Uh oh!

cocoanautz left a comment

Uh oh!

cocoanautz Feb 11, 2024

Uh oh!

cocoanautz Feb 11, 2024

Uh oh!

cocoanautz Feb 11, 2024

Uh oh!

cocoanautz Feb 11, 2024

Uh oh!

cocoanautz Feb 11, 2024

Uh oh!

HusseinSafwan02 left a comment

Uh oh!

HusseinSafwan02 Feb 13, 2024

Uh oh!

HusseinSafwan02 Feb 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

	tasks.add(new Deadline(task, parts[1]) );
	tasks.add(new Deadline(task, parts[1]));

	public static String added(Task task, int count) {
	public static String printAdded(Task task, int count) {

[Rena] iP #458

Are you sure you want to change the base?

[Rena] iP #458

Uh oh!

Conversation

Chiarena commented Feb 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Duke

Uh oh!

This comment was marked as off-topic.

Uh oh!

NewtonKoh left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cocoanautz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HusseinSafwan02 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Chiarena commented Feb 5, 2024 •

edited

Loading