Duke ip update by Ijaaz01 · Pull Request #175 · nus-cs2113-AY2324S2/ip

Ijaaz01 · 2024-02-06T16:13:16Z

Add Task.java to take care of tasks in list
Change Duke to Pythia
Add mood sprites for Pythia

YHWong20

Remember to add spaces between your operators:
https://se-education.org/guides/conventions/java/index.html#layout

YHWong20 · 2024-02-08T02:25:15Z

src/main/java/Duke.java

+import java.util.ArrayList;
+import java.util.List;
+import java.util.Scanner;
 public class Duke {


Insert a line break after your import statements.

YHWong20 · 2024-02-08T02:26:05Z

src/main/java/Duke.java

+            System.out.println((i+1)+"."+list.get(i).getDoneStatus()+" "+list.get(i).getDescription());
+        }
+    }
    public static void main(String[] args) {


Insert a line break between methods.

YHWong20 · 2024-02-08T02:27:50Z

src/main/java/Duke.java

 public class Duke {
+    public static void printList(List<Task> list) {
+        for (int i = 0; i < list.size(); i++) {
+            System.out.println((i+1)+"."+list.get(i).getDoneStatus()+" "+list.get(i).getDescription());


Insert spaces between your operators (in this case, insert spaces between your + to separate your operands).

YHWong20 · 2024-02-08T02:29:26Z

src/main/java/Duke.java

-                + "| |_| | |_| |   <  __/\n"
-                + "|____/ \\__,_|_|\\_\\___|\n";
-        System.out.println("Hello from\n" + logo);
+        String lineBreak = "----------------------------------------------------------";


Your lineBreak, idle and happy Strings should be set as constants. Declare them private final.

YHWong20 · 2024-02-08T02:31:31Z

src/main/java/Duke.java

+        String input = "Start";
+        List<Task> list = new ArrayList<>(2);
+        Scanner in = new Scanner(System.in);
+        System.out.println(idle + "Hello, Im Pythia, how may I help you today?\n"+lineBreak);


Add spaces between your + operator.

YHWong20 · 2024-02-08T02:31:51Z

src/main/java/Duke.java

+        List<Task> list = new ArrayList<>(2);
+        Scanner in = new Scanner(System.in);
+        System.out.println(idle + "Hello, Im Pythia, how may I help you today?\n"+lineBreak);
+        while (!input.equals("bye")) {


Add a line break before your while loop.

YHWong20 · 2024-02-08T02:33:18Z

src/main/java/Duke.java

+        System.out.println(idle + "Hello, Im Pythia, how may I help you today?\n"+lineBreak);
+        while (!input.equals("bye")) {
+            input = in.nextLine();
+            if (input.equalsIgnoreCase("list")) {


You are not following the K&R brace style for your if-else blocks.

YHWong20 · 2024-02-08T02:35:52Z

src/main/java/Task.java

+        isDone  = false;
+    }
+
+    public void doneIsFalse() {


Consider renaming your setter methods. Perhaps you could change it to setDoneAsTrue() or something?

HengShuHong

Good job so far keep it up!

HengShuHong · 2024-02-08T07:38:52Z

src/main/java/Duke.java

+            else if (input.contains("unmark ")) {
+                String[] splitInput = input.split(" ");
+                list.get(Integer.parseInt(splitInput[1])-1).doneIsFalse();
+                System.out.println("Unmarked "+ Integer.parseInt(splitInput[1]));


Add a space before + operator

HengShuHong · 2024-02-08T07:44:16Z

src/main/java/Duke.java

+            if (input.equalsIgnoreCase("list")) {
+                printList(list);
+            }
+            else if (input.contains("add ")) {


regarding the else if statement, the coding standard should be something like this
if (....) {
xxx;
} else if {
yyyy;
} else {
zzzz;
}

HengShuHong · 2024-02-08T07:45:43Z

src/main/java/Duke.java

+import java.util.ArrayList;
+import java.util.List;
+import java.util.Scanner;
 public class Duke {


not compulsory but would be good if you can rename the class according to the name of your chatbot

HengShuHong · 2024-02-08T07:47:51Z

src/main/java/Task.java

+    public String getDescription() {
+        return description;
+    }
+


additional line here that can be removed

aditichadha1310

Overall, Good job!

aditichadha1310 · 2024-02-18T05:08:28Z

src/main/java/Deadline.java

@@ -0,0 +1,14 @@
+public class Deadline extends Task {


Comments are missing. Good to have them for better readability.

aditichadha1310 · 2024-02-18T05:09:15Z

src/main/java/Duke.java

+    private static MoodSprite mood = new MoodSprite();
+    private static List<Task> list = new ArrayList<>(2);
+    private static Parser parser = new Parser();
+    private static final String lineBreak = "----------------------------------------------------------";


Good work with the usage of Access Modifiers.

aditichadha1310 · 2024-02-18T05:12:15Z

src/main/java/Event.java

+        super(description);
+        this.from = from.replaceFirst("from", "from:");
+        this.to =  to.replaceFirst("to", "to:");
+        this.taskId = "[E]";


Avoid the usage of Magic literals.

Add find functionality

Add JavaDoc for UI, Parser and Command classes

Ijaaz01 added 4 commits January 25, 2024 20:55

Duke.java: change chatbot name to Pythia

e3bb1f1

Duke.java: Increment level 1

550f897

Duke.java: increment level 2

6c2a44c

Duke.java: increment level 3

c9bf241

YHWong20 reviewed Feb 8, 2024

View reviewed changes

HengShuHong reviewed Feb 8, 2024

View reviewed changes

Ijaaz01 added 4 commits February 9, 2024 23:36

Level 4: add todo, deadline, event functionality

93f250d

Add PythiaException class

2ff2c78

Add throws and catches to main loop

617ba63

Merge branch 'branch-Level-5'

a9162e1

aditichadha1310 reviewed Feb 18, 2024

View reviewed changes

Ijaaz01 and others added 19 commits February 21, 2024 23:24

Add package duke

99083da

Merge branch 'branch-A-Packages'

36b6f21

Add delete functionality

b18d968

Add save functionality, jar file

11a53c8

Merge branch 'branch-Level-6'

9ed796b

Bug fix, add filewriter.close

8dd0afc

Merge branch 'branch-Level-7'

22bef9f

Fix format for event printing, save list automatically

c2444c9

Bug fixes

a608d2a

Refactor code, add command class, bug fix savedlist retrieval

0639287

Add find functionality

bfffd2b

Merge pull request #1 from Ijaaz01/branch-Level-9

f1019fd

Add find functionality

Add UI, TaskList, unparsedTaskList and Storage classes

8c70edb

Add JavaDoc for UI, Parser and Command classes

8fbb360

Merge pull request #2 from Ijaaz01/branch-A-JavaDoc

f35f2ba

Add JavaDoc for UI, Parser and Command classes

Add JavaDoc headers for Duke, Storage, TaskList and UnparsedTaskList

1f2ea47

Edit made to README.md file

1347803

Final touch ups to README file

f5e750d

Fix formatting error in README file

2b44fe6

Ijaaz01 added 2 commits March 8, 2024 20:06

Add help command and angry sprite

def90c3

Add help command to README file

12225f9

Conversation

Ijaaz01 commented Feb 6, 2024

Uh oh!

YHWong20 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HengShuHong left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aditichadha1310 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants