[shawnpong] iP by shawnpong · Pull Request #178 · nus-cs2113-AY2324S2/ip

shawnpong · 2024-02-07T03:34:12Z

No description provided.

Let's tweak the docs/README.md (which is used as the user guide) to fit Duke better. Specifically, 1. mention product name in the title 2. mention adding a product screenshot and a product intro 3. tweak the flow to describe feature-by-feature

Joshuahoky

Consider refactoring main in Floda.java into different methods to make the code easier to read and understand. Otherwise, code follows Java coding standard well and is of high quality

Joshuahoky · 2024-02-08T17:20:42Z

src/main/java/Deadline.java

+        this.by = by;
+    }
+
+    @Override


Great use of Override annotation to signal method overriding

Joshuahoky · 2024-02-08T17:22:25Z

src/main/java/Floda.java

+                    } else {
+                        System.out.println("Invalid task number! Please check with 'list'.");
+                    }
+                } else {


Avoid arrowhead style code

src/main/java/Floda.java

Joshuahoky · 2024-02-08T17:29:03Z

src/main/java/Floda.java

+
+public class Floda {
+    public static void main(String[] args) {
+        String name = "Floda";


Redundant code as it can be combined with the next line
eg. System.out.println("Hello! I'm Floda");

lordgareth10

Looks okay to me, the coding standards were mostly adhered to in general, however some parts which I commented on could be refactored to improve logical flow and readability.

lordgareth10 · 2024-02-09T09:15:56Z

src/main/java/Task.java

Could consider refactoring to use separate methods to handle individual command types. For example, if the command is "event" you could use a handleEventInput() method to parse the string and add the object to the list. This will improve readability considerably.

lordgareth10 · 2024-02-09T09:30:47Z

src/main/java/Floda.java

@@ -0,0 +1,83 @@
+import java.util.Scanner;


I like how you specified java.util.Scanner instead of java.util.* , this complies with coding standards, well done !

lordgareth10 · 2024-02-09T09:33:52Z

src/main/java/Floda.java

+
+public class Floda {
+    public static void main(String[] args) {
+        String name = "Floda";


Should this be a constant? And if it was then perhaps you could have used (public static final string) and capitalised the variable name (NAME) to follow the coding standards.

lordgareth10 · 2024-02-09T09:35:31Z

src/main/java/Floda.java

+        while (!"bye".equals((line = scanner.nextLine()))) {
+            if ("list".equals(line)) {
+                System.out.println("List so far: ");
+                for (int i = 0; i < taskCounter; i++) {
+                    System.out.println((i + 1) + "." + list[i]);
+                }
+            } else if (line.startsWith("mark")) {
+                Scanner taskScanner = new Scanner(line);
+                taskScanner.next();
+                if (taskScanner.hasNextInt()) {
+                    int taskNumber = taskScanner.nextInt() - 1;
+                    if (taskNumber >= 0 && taskNumber < taskCounter) {
+                        list[taskNumber].setDone(true);
+                        System.out.println("I have marked this task as done:\n" + list[taskNumber]);
+                    } else {
+                        System.out.println("Invalid task number! Please check with 'list'.");


Perhaps you could refactor the code into smaller methods that handle the logic without having to have so many levels of nesting, this would make the code more readable.

lordgareth10 · 2024-02-09T09:37:32Z

src/main/java/Task.java

+        this.description = description;
+    }
+
+    public boolean isDone() {


I like how the boolean method isDone is namd to sound like a boolean!

lordgareth10 · 2024-02-09T09:43:37Z

src/main/java/Floda.java

+        System.out.println("I can keep track of a to-do list for you! Just type what you want to add to the list.");
+        while (!"bye".equals((line = scanner.nextLine()))) {


It would improve readability if you directly assigned String line = scanner.nextLine() in the previous line instead of assigning it inside the conditional for the while loop. Then you could read in a new line of input at the end of every if else block.

…Level-5

This reverts commit a6f7324.

# Conflicts: # src/main/java/Floda.java

nichyjt

Hi Shawn,

Your code is generally well structured. Good job!

There are some repeated mistakes in the codebase (such as magic literals), so do take note.

There are some other specific comments below. Try and fix them before the next tutorial!

For your consideration: There is a way to autoformat your code automatically every time you Ctrl-S on intellij which will save you much pain. :)

nichyjt · 2024-02-23T11:41:24Z

src/main/java/Floda.java

+    private final static String NAME = "Floda";
+    private static final String FILE_PATH = "./data/tasks.txt";


I'm not sure why the NAME constant left out the static keyword?

src/main/java/Floda.java

Add branch

damithc and others added 11 commits January 7, 2024 18:33

docs/README.md: Tweak document template

55f9f9f

Let's tweak the docs/README.md (which is used as the user guide) to fit Duke better. Specifically, 1. mention product name in the title 2. mention adding a product screenshot and a product intro 3. tweak the flow to describe feature-by-feature

Add Gradle support

f837ddb

Bump gradle and lib version

a6f7324

Added name for my chatbot

acf8fdf

Added echo functionality for George

623f216

Added list tracking functionality

46afd35

Added mark, unmark functionality

66efd52

Changed bot name, abide by coding standard

8cb1b88

Add Task class

a37a35f

Add Task,ToDo, Deadline class

5195542

Follow coding standard

118c2de

Joshuahoky reviewed Feb 8, 2024

View reviewed changes

lordgareth10 reviewed Feb 9, 2024

View reviewed changes

shawnpong added 9 commits February 14, 2024 20:25

Add methods to handle different tasks

0e1e695

Add exception handling

ea1adcb

Fix bugs

2d89f52

Merge remote-tracking branch 'origin/add-gradle-support' into branch-…

190535f

…Level-5

Revert "Bump gradle and lib version"

14cbebb

This reverts commit a6f7324.

Merge remote-tracking branch 'origin/add-gradle-support'

f6e276f

Revert "Bump gradle and lib version"

a2c95c2

This reverts commit a6f7324.

Merge branch 'master' into branch-Level-5

3fd63f3

Remove files

52ab77b

shawnpong force-pushed the master branch from 9faeca5 to 2d89f52 Compare February 15, 2024 05:23

shawnpong added 7 commits February 16, 2024 16:04

Level-5

4894ef2

Merge branch 'branch-Level-5'

3992ded

Add more exception handling

4293c01

Implement ArrayList for dynamic array handling

a67bf9b

Add save functionality, gitignore list data

46d6cc1

Add gitignore

d3003ef

Merge branch 'branch-Level-7'

0c702d7

shawnpong added 2 commits February 21, 2024 18:14

Merge branch 'branch-Level-6'

aa38640

# Conflicts: # src/main/java/Floda.java

Fix bugs with regard to using ArrayList

2288a85

nichyjt reviewed Feb 23, 2024

View reviewed changes

shawnpong added 13 commits February 29, 2024 22:21

Add Parser, Storage, TaskList, Ui classes

db336b4

Add Find functionality

c8b6a97

Merge branch 'branch-Level-9'

c6a0097

Add JavaDoc to code

e7bc46d

Add branch

19e3ebf

Merge branch 'master' into branch-Level-9

f45955d

Merge pull request #1 from shawnpong/branch-Level-9

02ec784

Add branch

Testing README

6f0f9e7

Testing README

00aadd0

Add README user guide

8d5f63a

Update README with colours!

c7abf86

Change README colours

bb716bf

Add javadoc for ToDo

8dc40dc

		System.out.println("I can keep track of a to-do list for you! Just type what you want to add to the list.");
		while (!"bye".equals((line = scanner.nextLine()))) {

		private final static String NAME = "Floda";
		private static final String FILE_PATH = "./data/tasks.txt";

Conversation

shawnpong commented Feb 7, 2024

Uh oh!

Joshuahoky left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lordgareth10 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nichyjt left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants