[LIU SIYI] iP by 64-1 · Pull Request #184 · nus-cs2113-AY2324S2/ip

64-1 · 2024-02-07T16:32:16Z

No description provided.

JingHaoooo

Overall it looks good. Although there were some minor coding standard violations.

JingHaoooo · 2024-02-08T03:34:52Z

src/main/java/UserDetails.java

+            switch (input) {
+                case "1":
+                    gender = "Male";
+                    break;
+                case "2":
+                    gender = "Female";
+                    break;
+                case "3":
+                    gender = "Other";
+                    break;
+                default:
+                    System.out.println("Invalid option selected. Please enter 1, 2, or 3.");
+                    continue;
+            }
+            break; // Exit the loop once a valid input is received.


There should not be any indentation for case clauses to follow the coding standards.

JingHaoooo · 2024-02-08T03:41:26Z

src/main/java/Main.java

+        String message = String.format(
+                "Verification passed.\nOptions enabled.\n%s Born on %s\n%s\nID A.D.0013\n" +
+                        "Rank 'S'\nListed in the Kassel Academy roster.\n" +
+                        "Database access granted\nAccount activated\nCourse schedule generated\n" +
+                        "I am Erii, the secretary of Kassel Academy, pleased to serve you.",
+                name, birthday, gender);


I like the line wrapping. It makes it more readable.

JingHaoooo · 2024-02-08T03:44:43Z

src/main/java/TaskManager.java

@@ -0,0 +1,39 @@
+// TaskManager.java
+public class TaskManager {
+    private static final String[] tasks = new String[100];


Can consider setting 100 to a constant variable.

JingHaoooo · 2024-02-08T03:45:14Z

src/main/java/TaskManager.java

+    public static void addTask(String task) {
+        if (taskCount < tasks.length) {
+            tasks[taskCount++] = task;
+            System.out.println("____________________________________________________________");


Can consider changing divider to a constant.

JingHaoooo · 2024-02-08T03:48:48Z

src/main/java/UserDetails.java

+     *
+     * @return the user's full name
+     */
+    public static String getName() {


Naming of variables are good as it follows the naming conventions of using camelCase.

CXIA17 · 2024-02-08T03:56:07Z

src/main/java/TaskManager.java

+    public static boolean processCommand(String command) {
+        if ("list".equalsIgnoreCase(command)) {
+            listTasks();
+            return true;
+        } else if ("bye".equalsIgnoreCase(command)) {
+            System.out.println("____________________________________________________________");
+            System.out.println(" Bye. Hope to see you again soon!");
+            System.out.println("____________________________________________________________");
+            return false;
+        } else {
+            addTask(command);
+            return true;
+        }


Good indentation

CXIA17 · 2024-02-08T03:56:34Z

src/main/java/UserDetails.java

+            switch (input) {
+                case "1":
+                    gender = "Male";
+                    break;
+                case "2":
+                    gender = "Female";
+                    break;
+                case "3":
+                    gender = "Other";
+                    break;
+                default:
+                    System.out.println("Invalid option selected. Please enter 1, 2, or 3.");
+                    continue;


case and switch should be aligned, invalid indentation

hafizuddin-a

good code quality

hafizuddin-a · 2024-02-08T07:55:54Z

src/main/java/Erii.java

@@ -0,0 +1,27 @@
+public class Erii {
+    public static void main(String[] args) {
+        String art = 


perhaps move this to another file?

hafizuddin-a · 2024-02-08T07:57:57Z

src/main/java/UserDetails.java

@@ -0,0 +1,88 @@
+import java.util.Scanner;
+import java.util.regex.Matcher;


i like that you use regex

hafizuddin-a · 2024-02-08T07:58:22Z

src/main/java/UserDetails.java

+        System.out.println("Please enter your full name (First Name Last Name): ");
+        String name;
+        while (true) {
+            name = scanner.nextLine().trim();


good using trim to remove unnecessary characters

hafizuddin-a · 2024-02-08T08:00:11Z

src/main/java/TaskManager.java

+    }
+
+    public static boolean processCommand(String command) {
+        if ("list".equalsIgnoreCase(command)) {


good that you have a method to ignore case

CXIA17 · 2024-02-08T14:06:00Z

src/main/java/Erii.java

@@ -0,0 +1,27 @@
+public class Erii {
+    public static void main(String[] args) {
+        String art = 


Make variable names for constant all uppercase.

CXIA17 · 2024-02-08T14:10:56Z

src/main/java/UserDetails.java

+import java.util.Scanner;
+import java.util.regex.Matcher;


Import classes listed explicitly, good

Organized classes into dedicated packages for better modularity and maintainability. Created com.erii as the base package and subdivided functionalities into core, ui, and user packages respectively. Addresses issue nus-cs2113-AY2324S2#123 for project structure optimization.

sevenseasofbri

Good job, you can improve upon abstraction of the code. Else, well done. 👍🏽

sevenseasofbri · 2024-02-19T07:30:20Z

src/main/java/com/erii/Main.java

+        // Prompt the user to enter their details
+        String name = UserDetails.getName();
+        String birthday = UserDetails.getBirthday();
+        String gender = UserDetails.getGenderSelection();
+
+
+        // Print the user details with a welcome message
+        String message = String.format(
+                "Verification passed.\nOptions enabled.\n%s Born on %s\n%s\nID A.D.0013\n" +
+                        "Rank 'S'\nListed in the Kassel Academy roster.\n" +
+                        "Database access granted\nAccount activated\nCourse schedule generated\n" +
+                        "I am Erii, the secretary of Kassel Academy, pleased to serve you.",
+                name, birthday, gender);
+
+        System.out.println(message);
+
+        //Call control panel to start the task manager
+        ControlPanel.main(args);


These comments are not required as it is quite clear from the code already.

sevenseasofbri · 2024-02-19T07:30:58Z

src/main/java/com/erii/core/Erii.java

+
+public class Erii {
+    public static void main(String[] args) {
+        String art = 


consider storing this art as a static final variable

sevenseasofbri · 2024-02-19T07:31:12Z

src/main/java/com/erii/core/TaskManager.java

+
+public class TaskManager {
+
+    public enum Priority {


good use of enum

sevenseasofbri · 2024-02-19T07:32:19Z

src/main/java/com/erii/core/TaskManager.java

+        SS, S, A, B, C, D
+    }
+
+    public abstract class Task {


avoid declaring multiple classes within a same file, try an separate them into differen files (to improve readability)

sevenseasofbri · 2024-02-19T07:33:22Z

src/main/java/com/erii/core/TaskManager.java

+        System.out.println("Got it. I've added this task:");
+        System.out.println("  " + task);
+        System.out.println("Now you have " + tasks.size() + " tasks in the list.");
+        System.out.println("____________________________________________________________");


you can store is line as a static final variable instead

sevenseasofbri · 2024-02-19T07:39:01Z

src/main/java/com/erii/ui/ControlPanel.java

+    private static void addDeadlineTask(String input, TaskManager taskManager) {
+        String[] parts = input.split(" ?/by |  ?/ ?");
+        if(parts.length < 3 || parts[1].isEmpty() || parts[2].isEmpty()){
+            System.out.println("Incorrect format. Please ensure the task description is followed by '/by' and a deadline date, and then a priority value (e.g., 'submit report /by 2021-09-30 /SS').");


similarly here, split into 2 lines to avoid exceeding the line character limit.

sevenseasofbri · 2024-02-19T07:42:24Z

src/main/java/com/erii/ui/ControlPanel.java

+        }
+    }
+
+    private static String getAddress() {


the name of this function is a little misleading perhaps? I understand it probably refers to how to 'address' someone, but maybe use a word like salutation or userTitle instead?

sevenseasofbri · 2024-02-19T07:43:20Z

src/main/java/com/erii/user/UserDetails.java

+    private static final Scanner scanner = new Scanner(System.in);
+    private static final Pattern datePattern = Pattern.compile("^\\d{2}/\\d{2}/\\d{4}$");


Constant names must be all uppercase using underscore to separate words (aka SCREAMING_SNAKE_CASE).

https://se-education.org/guides/conventions/java/basic.html#naming

sevenseasofbri · 2024-02-19T07:43:40Z

src/main/java/com/erii/user/UserDetails.java

+    private static String UserName = "";
+    private static String UserBirthday = "";
+    private static String UserGender = "";


Variable names must be in camelCase.

https://se-education.org/guides/conventions/java/basic.html#naming

sevenseasofbri · 2024-02-19T07:45:32Z

src/main/java/com/erii/ui/ControlPanel.java

+
+public class ControlPanel {
+
+    public static void main(String[] args) {


this method is really long (>30 LOC) shorten it by abstracting out parts of code into functions

https://nus-cs2113-ay2324s2.github.io/website/se-book-adapted/chapters/codeQuality.html#avoid-long-methods

This reverts commit 5eee43e.

Enhance event and deadline date handling with time support

Implement task search by keyword

This reverts commit 007e4ab.

(cherry picked from commit 007e4ab)

…nd end of the file

64-1 added 2 commits February 7, 2024 21:38

change name of Duke.java into Erii.java

198bd9c

Added UserDetail and TaskManager classes

46c5bbe

JingHaoooo reviewed Feb 8, 2024

View reviewed changes

CXIA17 reviewed Feb 8, 2024

View reviewed changes

hafizuddin-a reviewed Feb 8, 2024

View reviewed changes

CXIA17 reviewed Feb 8, 2024

View reviewed changes

64-1 and others added 15 commits February 9, 2024 00:05

Added ControlPanel class and modified taskmanager

b6bd1ed

Optimised ControlPanel and TaskManager

90f4de3

Encapsulated task priority validation

11aa4b1

Added displayMenu method for ControlPanel

80e6149

Adjusted validatePriority method

d81e62e

Merge branch 'branch-Level-5'

af93e4d

Update README.md

badde63

Update README.md

ca1a678

Update README.md

904d91b

Update README.md

5b505fc

Update README.md

5eeeab8

Update README.md

ef1f2cf

Update README.md

730f971

Add delete task function

b2e1eb9

sevenseasofbri reviewed Feb 19, 2024

View reviewed changes

64-1 and others added 7 commits February 25, 2024 00:42

Add data saving function and encapsulate control panel class

29e7978

Adjust data storage class

0a49677

After braching gradle

5eee43e

Revert "After braching gradle"

84408cb

This reverts commit 5eee43e.

Creater JAR file

b6f3bc8

Update annotation

214d34d

Update README.md

c58e7b1

64-1 and others added 30 commits February 25, 2024 17:53

Enhance event and deadline date handling with time support

ec0fb98

Merge pull request #1 from 64-1/branch-Level-8

a8ef21f

Enhance event and deadline date handling with time support

Implement task search by keyword

f4bd435

Merge pull request #2 from 64-1/branch-Level-9

eda80a9

Implement task search by keyword

Add documentation

007e4ab

Revert "Add documentation"

0d8af09

This reverts commit 007e4ab.

Add documentation

2b39244

(cherry picked from commit 007e4ab)

Merge branch 'branch-Level-9'

16afdc4

Update README.md

688d2d1

Update README.md

b387ab5

Update README.md

8061302

Update README.md

3eee41b

Update README.md

b28600d

Update README.md

82599ce

no message

0e3906a

Update Erii Functional Overview

707e143

Delete ip.jar

29694c2

Update README.md with user guide and main features

e89d762

Refactor data storage and control panel classes

5b3b7a7

Remove tasks and user details

b47dd6c

Adjust user details and task management functionality

81cc077

Add taskToFileString() and fileStringToTask() methods

76644da

Refactor taskToFileString and fileStringToTask methods

0ecf009

Refactor TaskManager class by removing empty lines at the beginning a…

32022b9

…nd end of the file

Add new options for listing tasks by date and searching

3daf4b1

Update README.md

8b38d92

Refactor task type validation and add search by date feature

d39c989

Merge branch 'master' of https://github.com/64-1/ip

219420f

Update userDetails.txt and EXPECTED.TXT

daecde6

Update .gitignore to include Erii.jar

90ea34f

		@@ -0,0 +1,88 @@
		import java.util.Scanner;
		import java.util.regex.Matcher;

		private static final Scanner scanner = new Scanner(System.in);
		private static final Pattern datePattern = Pattern.compile("^\\d{2}/\\d{2}/\\d{4}$");


		public class ControlPanel {

		public static void main(String[] args) {

Conversation

64-1 commented Feb 7, 2024

Uh oh!

JingHaoooo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CXIA17 Feb 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hafizuddin-a left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sevenseasofbri left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

CXIA17 Feb 8, 2024 •

edited

Loading