Conversation
(cherry picked from commit df84b6a5039882942c1596bfb81b04083e6d9626)
yicheng-toh
left a comment
yicheng-toh
left a comment
There was a problem hiding this comment.
Great progress on iP. Do take note to follow the coding standards from java coding standard.
src/main/java/Deadline.java
Outdated
| /* | ||
| public String getBy() { | ||
| return this.by; | ||
| } | ||
|
|
||
| public String setBy() { | ||
| return this.by; | ||
| }*/ |
There was a problem hiding this comment.
| /* | |
| public String getBy() { | |
| return this.by; | |
| } | |
| public String setBy() { | |
| return this.by; | |
| }*/ |
Perhaps you might want to remove commented code that are not in use.
src/main/java/Duke.java
Outdated
| import java.util.Scanner; | ||
| import java.util.ArrayList; | ||
|
|
||
| // I am using the Google Java Style Guide https://google.github.io/styleguide/javaguide.html |
There was a problem hiding this comment.
For this module, we are following this java coding standard.
src/main/java/Duke.java
Outdated
| System.out.printf("%s%n"," ____________________________________________________________"); | ||
| } | ||
|
|
||
| public static void replyAddedTask(){ |
There was a problem hiding this comment.
| public static void replyAddedTask(){ | |
| public static void replyAddedTask() { |
Perhaps considering adding a space here to be consistent with the rest of the methods.
src/main/java/Duke.java
Outdated
| String taskType=userCommand.split(" ")[0].toUpperCase(); | ||
|
|
||
| switch (taskType) { | ||
| default: |
There was a problem hiding this comment.
Perhaps you might want to put "default" statement at the end of the switch statements.
src/main/java/Duke.java
Outdated
| break; | ||
|
|
||
| case "DEADLINE": | ||
| String[] deadLine=userCommand.split("/"); |
There was a problem hiding this comment.
| String[] deadLine=userCommand.split("/"); | |
| String[] deadLine = userCommand.split("/"); |
You might want to consider adding spaces before and after the "=" sign for better readability.
src/main/java/Duke.java
Outdated
|
|
||
| switch (markChoice) { | ||
|
|
||
| case "MARK": |
There was a problem hiding this comment.
| case "MARK": | |
| case "MARK": |
Perhaps you might want to put the case statements with same amount of indentation with the switch statement in accordance to java coding standard.
src/main/java/Duke.java
Outdated
| boolean shouldExitLoop=false; | ||
|
|
||
| while (!shouldExitLoop) { | ||
| if (enteredCommands.size()>=100) { |
There was a problem hiding this comment.
You might want to consider using a constant to replace the magic number of 100.
Add Level-5: exception handling, packages & classes
Add 'find KEYWORD' command support
2 participants
No description provided.