Skip to content

Conversation

@CSharperMantle
Copy link
Contributor

@CSharperMantle CSharperMantle commented Jun 4, 2025

@github-actions
Copy link

github-actions bot commented Jun 4, 2025

Script Analysis

  • The change modifies a path existence check to handle quoted commandline paths in Windows Terminal profiles
  • Uses str trim --char '"' to properly handle quoted executable paths which is a common Windows Terminal configuration
  • Maintains all existing assertions for profile validation
  • Follows Nu's structured data handling approach by using get on the profile object

Security Review

  • No direct security vulnerabilities introduced
  • The change actually improves reliability by properly handling quoted paths which could previously cause false negatives
  • No command injection risks as this is only checking path existence
  • No sensitive data exposure in the assertions

Optimization Suggestions

  • Consider using path expand in addition to str trim for more robust path handling
  • Could potentially combine the path existence checks into a single pipeline for slightly better performance
  • The change is already quite efficient as it uses built-in commands and maintains lazy evaluation

Overall Quality: 4 (The change is solid but could be slightly more robust with path expansion)

sholderbach pushed a commit to nushell/nushell that referenced this pull request Jun 4, 2025
# Description

This PR fixes regressions introduced by #15881.

# User-Facing Changes

None.

# Tests + Formatting

See nushell/integrations#57.

# After Submitting

None.
@CSharperMantle
Copy link
Contributor Author

Are these workflows running against HEAD or the latest nightly artifacts?

@hustcer
Copy link
Contributor

hustcer commented Jun 4, 2025

Are these workflows running against HEAD or the latest nightly artifacts?

They run against the latest nightly builds, and It's scheduled to run every morning, I have just started the nightly build workflow manually

@hustcer hustcer merged commit 57b7650 into nushell:main Jun 4, 2025
9 of 18 checks passed
kumarUjjawal pushed a commit to kumarUjjawal/nushell that referenced this pull request Jun 5, 2025
# Description

This PR fixes regressions introduced by nushell#15881.

# User-Facing Changes

None.

# Tests + Formatting

See nushell/integrations#57.

# After Submitting

None.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants