Skip to content

Conversation

@hustcer
Copy link
Contributor

@hustcer hustcer commented Jun 10, 2025

Add just bump task to bump version and create tag automatically, fixes #54

@hustcer hustcer merged commit 657dc5a into main Jun 10, 2025
95 of 97 checks passed
@github-actions
Copy link

Script Analysis

  • The changes introduce a new version bumping utility (bump-ver.nu) with proper version format validation
  • Added version parameter to release fetching functions to ensure specific version downloads
  • Improved structured data handling in meta.json (changed revision from string to number)
  • Added proper error handling and validation in version bumping process
  • Using string interpolation for version/subcommand parameters rather than string concatenation

Security Review

  • ❗ The signing key is being handled directly from environment without sanitization (line 52/95 in publish.yml)
  • ⚠️ Temporary GPG key file is created but no explicit permissions are set (potential race condition)
  • The git operations in bump-ver.nu perform direct branch operations without verification of remote state

Optimization Suggestions

  • Replace direct file open (open meta.json) with structured input parsing in bump-ver.nu
  • Consider parallelizing the architecture-specific release operations in publish.yml
  • Add version caching to avoid repeated meta.json parsing in workflow steps
  • Use par-each for multiple architecture handling where possible

Overall Quality: 4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add just bump task to bump version and create tag automatically

2 participants