Skip to content

Conversation

@hustcer
Copy link
Contributor

@hustcer hustcer commented Jul 28, 2025

Test winget upgrade for the latest nightly builds

@github-actions
Copy link

Script Analysis

  • Added new --local flag to control manifest-based vs direct winget installation
  • Improved version handling by using get-latest-tag for non-local installations
  • Better separation of concerns with prepare-manifest now exported and used explicitly
  • Added conditional logic for MSI tests requiring both --msi and --local flags
  • Maintained structured data flow with version checks and installation verification

Security Review

  • ❗ Potential path injection risk in manifest paths (e.g., manifests\n\Nushell\Nushell\($version)\)
  • ⚠️ Direct execution of winget install without input validation for version strings
  • GITHUB_TOKEN exposed in workflow (though necessary for GitHub Actions)

Optimization Suggestions

  • Replace string concatenation with path joining for manifest paths
  • Consider caching the result of get-latest-tag to avoid repeated calls
  • Use structured version comparison instead of string splitting where possible
  • Add parallel execution for independent test cases where possible

Overall Quality: 4

@hustcer hustcer merged commit 4e38844 into main Jul 28, 2025
71 checks passed
hustcer added a commit that referenced this pull request Jul 28, 2025
Test winget upgrade for the latest nightly builds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants