Parser improvements #24
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: innocentzero <[email protected]>
Signed-off-by: innocentzero <[email protected]>
Signed-off-by: innocentzero <[email protected]>
Signed-off-by: innocentzero <[email protected]>
Signed-off-by: innocentzero <[email protected]>
Signed-off-by: innocentzero <[email protected]>
Both of them are redundant now given that blocks return the type of the last statement Signed-off-by: innocentzero <[email protected]>
Signed-off-by: innocentzero <[email protected]>
Signed-off-by: innocentzero <[email protected]>
Implements OneOf for if-else and def nodes Signed-off-by: innocentzero <[email protected]>
Signed-off-by: innocentzero <[email protected]>
Signed-off-by: innocentzero <[email protected]>
Signed-off-by: innocentzero <[email protected]>
Signed-off-by: innocentzero <[email protected]>
Signed-off-by: innocentzero <[email protected]>
InnocentZero
force-pushed
the
parse-improvements
branch
2 times, most recently
from
dcc76ff to
2f38bf7
Compare
Signed-off-by: innocentzero <[email protected]>
InnocentZero
force-pushed
the
parse-improvements
branch
from
2f38bf7 to
a921e5a
Compare
Signed-off-by: innocentzero <[email protected]>
InnocentZero
force-pushed
the
parse-improvements
branch
from
a921e5a to
3130dd6
Compare
This is used to indicate the type status in case of an error to avoid ambiguities around the usage of other types Signed-off-by: innocentzero <[email protected]>
kubouch
reviewed
Dec 15, 2024
|
|
||
| if self.is_operator() { | ||
| // TODO: flag parsing | ||
| self.next(); |
Contributor
There was a problem hiding this comment.
Maybe throw an error here with a WIP note instead of silently ignoring flags.
Contributor
|
Haven't checked it too thoroughly, but also seems good. Flags with aliases we can add once we have proper signatures etc. |
Since params are not supposed to be evaluated, their type is changed to Forbidden Signed-off-by: innocentzero <[email protected]>
Match not returning anything should be a nothing type as it is an expression. The type for a for loop is now None, which matches the current nushell implementation. Signed-off-by: innocentzero <[email protected]>
Contributor
Author
|
I was going to add flags next, but it seems to be involved deeply with the parser and since you're rewriting the lexer which will move parts of the parser, I'll wait for it to settle a little bit. For now, I'll rebase once #19 is accepted and add the error for flags. |
Signed-off-by: innocentzero <[email protected]>
Signed-off-by: innocentzero <[email protected]>
Signed-off-by: innocentzero <[email protected]>
Define an alias node to parse, resolve and typecheck aliases Signed-off-by: innocentzero <[email protected]>
Signed-off-by: innocentzero <[email protected]>
InnocentZero
force-pushed
the
parse-improvements
branch
from
3130dd6 to
fdb4f25
Compare
Contributor
Author
|
I'm closing this in favour of #29 This one became a mess after my previous PR was merged and I wasn't able to resolve it easily. |
kubouch
pushed a commit
that referenced
this pull request
Jan 8, 2025
Supersedes #24 as it had too many merge conflicts with main. --------- Signed-off-by: innocentzero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
()) properly nowDepends on #19 so that needs to get merged first.