Initial generation of IR from nu AST. #30
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doriath
force-pushed
the
push-kosuysyztkqo
branch
from
9b08fca to
0cbd564
Compare
The initial implementation only handles simple math expressions, the focus is primarily on introducing new structs, agreeing on naming and adding the output to insta tests.
doriath
force-pushed
the
push-kosuysyztkqo
branch
from
0cbd564 to
1ebddec
Compare
kubouch
reviewed
Dec 28, 2024
|
|
||
| [dependencies] | ||
| tracy-client = { version = "0.17.3", default-features = false } # for tracy v0.11.1 | ||
| nu-protocol = "*" |
Contributor
There was a problem hiding this comment.
It's better to use a labeled version and bump manually to avoid sudden CI breakages.
| let mut next_free_reg = RegId::new(0); | ||
| let mut last_reg = RegId::new(0); | ||
| let mut node_to_reg: HashMap<NodeId, RegId> = HashMap::new(); | ||
| for (i, ast_node) in self.compiler.ast_nodes.iter().enumerate() { |
Contributor
There was a problem hiding this comment.
Shouldn't this start from the top-level block, like Resolver or Typechecker?
Contributor
Author
|
Sorry for closing it, will revive it soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial implementation only handles simple math expressions, the focus is primarily on introducing new structs, agreeing on naming and adding the output to insta tests.