-
Notifications
You must be signed in to change notification settings - Fork 9
Lexer and parser refactor #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small improvement
~10% improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The on-demand lexer is replaced with a standalone lexing pass using the Logos crate. The lexing code is refactored away from the parser into a separate data structure. The Parser is refactored and simplified accordingly.
The new lexer correctly recognizes more syntactic shapes than the previous one.
The new lexer+parser seems slightly faster (5-6 ms together on the combined1000.nu benchmark) than the previous version, but the main benefit is the lexer disentangled from the parser code. It is now possible to change the lexer more easily, including turning it into an on-demand lexer again if need be.
The main shortcomings are:
$"foo(1 + 2)bar". We'd need to switch to another lexer. It might be easier to use on-demand lexing for it.Notable API changes:
self.peek()->self.tokens.peek()self.next()-> gone, useself.tokens.advance()to point at the next tokens followed byself.tokens.peek().