Skip to content

Move file i/o out of benchmarked code #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kubouch merged 1 commit into from
Jan 8, 2025
Merged

Move file i/o out of benchmarked code #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions benches/benchmarks.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,13 +224,14 @@ fn compiler_benchmarks() -> impl IntoBenchmarks {
for bench_name in BENCHMARKS {
for stage in STAGES {
let bench_file = format!("benches/nu/{bench_name}.nu");
let bench_contents =
std::fs::read(&bench_file).expect(&format!("Cannot find file {bench_file}"));

let bench = match stage {
Stage::Lex => {
let name = format!("{bench_name}_lex");
benchmark_fn(name, move |b| {
let contents = std::fs::read(&bench_file)
.expect(&format!("Cannot find file {bench_file}"));
let contents = bench_contents.clone();
b.iter(move || {
let (tokens, err) = lex(&contents, 0);
if let Err(e) = err {
Expand All @@ -247,8 +248,7 @@ fn compiler_benchmarks() -> impl IntoBenchmarks {
let (compiler_def_init, span_offset) =
setup_compiler(&bench_file, false, false, false)
.expect("Error setting up compiler");
let contents = std::fs::read(&bench_file)
.expect(&format!("Cannot find file {bench_file}"));
let contents = bench_contents.clone();
let (tokens, err) = lex(&contents, span_offset);
if let Err(e) = err {
tokens.eprint(&contents);
Expand Down Expand Up @@ -307,8 +307,7 @@ fn compiler_benchmarks() -> impl IntoBenchmarks {
let name = format!("{bench_name}_nu_old");
benchmark_fn(name, move |b| {
let engine_state = make_engine_state();
let contents = std::fs::read(bench_file.clone())
.expect(&format!("Cannot find file {bench_file}"));
let contents = bench_contents.clone();
b.iter(move || parse_nu_old(&engine_state, &contents))
})
}
Expand Down