panache-git: exclude prompt indicator so user can choose their own #1012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, panache-git included a prompt indicator (`> `) out of the box, and the advice for the user was to remove Nushell's own configurable prompt indicator by setting it to the empty string. However, this conflicted with some of Nushell's intended functionality, such as the ability to use a different prompt indicator in each vi mode. With this change, panache-git does not include a prompt indicator. The advice is for the user to use the prompt indicator they like, but to reset the color so it better matches panache-git's colors. This is something of a breaking change, in that users who update to the latest panache-git.nu without making corresponding changes to their Nushell config might see two prompt indicators (`> > `), but my hope is that giving users (especially vi mode users) more flexibility with their prompt indicators will be worth any temporary confusion.
Contributor
|
Agreed. Nice catch. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, panache-git included a prompt indicator (
>) out of the box, and the advice for the user was to remove Nushell's own configurable prompt indicator by setting it to the empty string.However, this conflicted with some of Nushell's intended functionality, such as the ability to use a different prompt indicator in each vi mode.
With this change, panache-git does not include a prompt indicator. The advice is for the user to use the prompt indicator they like, but to reset the color so it better matches panache-git's colors.
This is something of a breaking change, in that users who update to the latest panache-git.nu without making corresponding changes to their Nushell config might see two prompt indicators (
> >), but my hope is that giving users (especially vi mode users) more flexibility with their prompt indicators will be worth any temporary confusion.