Fix failing lints on source files #1049
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #791 (and possibly before), any non-module Nushell file pushed to
nu_scriptswill fail CI since it attempts touse <file.nu>during linting.In addition, the #791 implementation could execute code during linting, since it actually imported potentially working code.
This PR updates the toolkit testing to:
exportline in the file.nu-checkon files before linting withuse <file>orsource <file>TEST_METHODwith options foride-checkorimport-or-source.import-or-source(waside-check) to match CIWith this in place we should have far fewer (false positive) failing CI runs.