feat: ani-cli completions rework #1149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nushell provides convenient syntax for this
usage of words in plural is my liking, but camel case shouldn't be used anyway
styling of the parameters is done like the help menu of the ani-cli itself. imo it's more convenient to read and edit. also it's less than 80 symbols in width for the terminal.
some of them are just non-existent (i couldn't find them either in man page or help output). it's pretty important, because if the option doesn't exist, then the script will not output an error, but silently ignore it and use this option as the part of the query.
with that, change the command description to official man description. and add query parameter name.
bring parameters with completions to the top for easy eye access for the functions. then non-boolean parameters and parameters with shorthand syntax. and everything else that remains.
sorry to the previous contributors, but first comment is treated as the description for the module. also, contributors history can be viewed in the repository. as for the indent: sorry, but i like 4 spaces more.
maybe it's too much for a simple extern module for one command, and also not so good on performance, but i think a little bit of that extra functionality can be more useful
because ani-cli parses the query this way (found while making examples)
Contributor
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
most of the changes are in the commit descriptions, but briefly it just a rework of ani-cli completions. there were some outdated (or just non-existent from the start) parameters, some errors and i didn't like the styling. while at it, i added more functionality to the completions, examples and remaining options.