Drop experimental label from display_output hook #1644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per comment nushell/nushell#14361 (comment) it's not clear what "experimental" would mean, the hook was introduced two years ago and has been stable since, and in #14361 there is a discussion about the hooks behavior but no indication that it would be dropped. Dropping the experimental label makes it more obvious that the hook is here to stay. If its behavior will change, it can be documented like usual in release breaking change notes (which would make sense anyway). As a drive-by text form fixup, drop the period from the last two list items. None of the other list items end in a period, which matches common form for [simple] lists.
Contributor
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hook was introduced two years ago and has been stable since. In #14361 there is a discussion about the hook's behavior but no indication that it could be dropped.
Dropping the experimental label makes it more obvious that the hook is here to stay. If its behavior changes, it can be documented like usual in release breaking change notes which would make sense anyway.
As a drive-by text form fixup, drop the period from the last two list items. None of the other list items end in a period, which matches the common English form for [simple] lists.