Es and fr book #1697
Merged
Es and fr book #1697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotTheDr01ds
requested changes
Dec 22, 2024
Contributor
NotTheDr01ds
left a comment
NotTheDr01ds
left a comment
There was a problem hiding this comment.
Thanks! A few more minor tweaks.
I'm also finding out just how outdated some of these translations are - Apparently the Spanish one still includes an add command example, which was renamed to insert in 2019 apparently!
Co-authored-by: Douglas <[email protected]>
Co-authored-by: Douglas <[email protected]>
Co-authored-by: Douglas <[email protected]>
NotTheDr01ds
requested changes
Dec 31, 2024
Contributor
NotTheDr01ds
left a comment
NotTheDr01ds
left a comment
There was a problem hiding this comment.
Thank you again, and apologies for not getting the reviews on these done sooner. Just a few things on this one and it will be ready.
From review
From review
From review
From review
NotTheDr01ds
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out Spanish and French for #1684. Didn't appear to have any of the same indentation issues but I could be a bit tab-blind after all this, lol.