Add libc feature to enable crossterm's libc backend#1014
Merged
fdncred merged 3 commits intonushell:mainfrom Feb 7, 2026
Merged
Add libc feature to enable crossterm's libc backend#1014fdncred merged 3 commits intonushell:mainfrom
libc feature to enable crossterm's libc backend#1014fdncred merged 3 commits intonushell:mainfrom
Conversation
Such that reedline can use crossterm with the libc feature.
Contributor
|
Seems reasonable. Just need to get the CI green, which I think is because of the lock file not being included in the PR. |
Contributor
|
update the lock file and we'll be good to go. Is that something you can do @NiltonVolpato ? |
Contributor
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
libcfeature that enables crossterm'slibcfeature, allowing reedline to work in environments where rustix's raw syscall approach fails.Motivation
When running under x86 emulation (e.g., CheerpX/WebVM, QEMU user-mode), reedline fails with:
The root cause is that rustix uses the
TCGETS2ioctl via raw syscalls, which some emulators don't implement. See:Crossterm has a
libcfeature that uses libc'stcgetattrinstead, which falls back toTCGETSand works in these environments.Changes
libcfeature that enablescrossterm/libcUsage