OSC 133 click_events support

[stuartcarnie]

This PR builds on #1019 to add support for OSC 133 click_events=1. It is in draft for @fdncred to evaluate

[fdncred]

I've updated my PR so you may want to rebase again, or just wait until it's landed. Mitchell gave some advice that I decided to take with regards to 133;A vs 133;P, which is basically to always use 133;P.

[stuartcarnie]

@fdncred I updated my branch too – using Nushell with all the goodies now!

[fdncred]

@stuartcarnie is there a difference in the cl versus the click_events? mitchellh is saying here that we may get cl for free with osc133 #1019 (comment)

[fdncred]

I landed #1019. when you have time it would be great to rebase

[mitchellh]

@stuartcarnie is there a difference in the cl versus the click_events? mitchellh is saying here that we may get cl for free with osc133 #1019 (comment)

click_events is significantly better if the shell can support it. It basically delegates all cursor movement to the shell (which is the source of truth that actually REALLY knows how all the navigation should work on the prompt line). It's just more work to implement than cl, which you're already getting for free with the recent OSC133 changes. If you can support click_events too that'd be ace!

Ghostty supports click_events along with Kitty, so probably should use both of those to verify this work. Thank you so much!

[stuartcarnie]

@mitchellh / @fdncred yup, I implemented support for click_events and have been using it in Nushell + Ghostty for the past week – works great!

[fdncred]

yay! I'll land this PR once it's green again and i have another quick trip through the code. Thanks @stuartcarnie!!

[stuartcarnie]

@fdncred done!

[fdncred]

Just some minor tweaks. Let me know if you think this is wrong. See this for reference.

reedline/src/terminal_extensions/semantic_prompt.rs

Lines 13 to 17 in 57f8c6a

	//! Thanks to mitchellh for this tidbit, "The `A` is kind of weird: it does
	//! a `\r\n` _if the cursor isn't at x=0_ and THEN does a `P`. If you want,
	//! you can use `P` all the time instead of `A` for example if you're not
	//! sure if the cursor will be at x=0." So, with that in mind, we'll use `P`
	//! for right prompts and left prompts.

[fdncred]

Wow, this is a cool PR! Other than the comments I already made I'd just like to say thanks for doing such a good job. Looking forward to landing this.

I wish I could find a terminal on Windows that worked. I've tried Windows Terminal, Alacritty, WezTerm and don't see this working. I assume those terminals just don't support click_events.

[stuartcarnie]

I wish I could find a terminal on Windows that worked. I've tried Windows Terminal, Alacritty, WezTerm and don't see this working. I assume those terminals just don't support click_events.

According to Mitchell, only Kitty and now Ghostty support click_events

I'll make the other changes shortly

[fdncred]

Just so you know my plan, this is it.

1. Land add native semantic prompt support initially for OSC 133/633 #1019 (done)
2. Land OSC 133 click_events support #1020
3. Land Add OSC 133 P (k=) markers for semantic prompts nushell#17468
4. Land feat: enable OSC133 click events via reedline nushell#17491
5. TBD - move other OSC escapes from nushell over to reedline (help wanted if you're interested)
6. TBD - are there other escapes that ghostty supports that we could/should add? if so, let's do it.

I'd like to land these in order as soon as we can. No rush, just sharing.

[stuartcarnie]

@fdncred I'm going to push the changes shortly – also added a couple of minor optimisations

[fdncred]

Let's go!

[stuartcarnie]

@fdncred it's ready – I'd like to refactor layout logic into a separate structure in a future PR, so that painting and snapshotting use the same logic

[fdncred]

@fdncred it's ready – I'd like to refactor layout logic into a separate structure in a future PR, so that painting and snapshotting use the same logic

Sure. Ping me when you have something and I'll look it over!