Skip to content

Conversation

@Juhan280
Copy link
Contributor

@Juhan280 Juhan280 commented Feb 9, 2026

This adds new ReedlineEvent variants for moving to the start and end of the buffer. These are added alongside existing EditCommands to provide a more direct way to trigger these movements. These were added to allow traversing the history after moving the cursor the start or end of the buffer.

The default Emacs and Vi keybindings have been updated to use them. But in visual mode, we are still using the EditCommand variants.

This adds new ReedlineEvent variants for moving to the start and end of the
buffer. These are added alongside existing EditCommands to provide a more
direct way to trigger these movements. These were added to allow
traversing the history after moving the cursor the start or end of the
buffer
The default Emacs and Vi keybindings have been updated to use them.
could be improved
@Juhan280
Copy link
Contributor Author

Juhan280 commented Feb 9, 2026

If you have suggestions for more better enum variant name or doc, please share.

Also in src/edit_mode/vi/motion.rs, there are todo comments for Motion::Up and Motion::Down arm of the to_reedline method. If what have I done so far makes sense, I can also add their EditCommand variants to make them work in visual mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant