Remove questionable unsafe impl Send#869
Open
sholderbach wants to merge 1 commit intonushell:mainfrom
Open
Conversation
`HistoryCompleter` is not `Send` due to it containing a reference to a `&dyn History` which was only `trait History: Send`. Here the property of a type T needing to implement `Sync` for its `&T` to be `Send` comes into play. Thus this `unsafe impl Send` is unsound. The change of making `trait History: Send + Sync` makes `HistoryCompleter: Send` automatically and should be compatible for all sound implementations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HistoryCompleteris notSenddue to it containing a reference to a&dyn Historywhich was onlytrait History: Send.Here the property of a type T needing to implement
Syncfor its&Tto beSendcomes into play. Thus thisunsafe impl Sendis unsound.The change of making
trait History: Send + SyncmakesHistoryCompleter: Sendautomatically and should be compatible for all sound implementations.